-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspend/resume/reconcile Image Repositories #3831
Merged
joshri
merged 14 commits into
main
from
3820-suspend-resume-reconcile-image-repositories
Jul 25, 2023
Merged
Suspend/resume/reconcile Image Repositories #3831
joshri
merged 14 commits into
main
from
3820-suspend-resume-reconcile-image-repositories
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
changed the title
3820 suspend resume reconcile image repositories
Suspend/resume/reconcile Image Repositories
Jul 9, 2023
opudrovs
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
4 times, most recently
from
July 9, 2023 21:38
3b9c2c2
to
b5a9403
Compare
joshri
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
from
July 14, 2023 16:39
b5a9403
to
71c7056
Compare
opudrovs
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
11 times, most recently
from
July 25, 2023 00:23
08e33df
to
306b0d8
Compare
…mageUpdateAutomations` to `wego-admin-cluster-role`.
…y` as a client object.
…mageRepositories table.
…add img repo sync test
…rce details pages with the SyncActions component. Add SyncActions component on the Image Repository Details page.
yiannistri
force-pushed
the
3820-suspend-resume-reconcile-image-repositories
branch
from
July 25, 2023 09:12
564a74b
to
f7198f3
Compare
yiannistri
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend code looks fine 👌 @joshri can you please review the UI part?
joshri
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chanwit
added
type/enhancement
New feature or request
area/ui
Issues that require front-end work
labels
Jul 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3820
Closes #3821
Added explicit permissions for
ImagePolicies
,ImageRepositories
,ImageUpdateAutomations
towego-admin-cluster-role
.Added
ImageRepositoryAdapter
to makeImageRepositories
reconcilable in the UI.Registered the
ImageRepository
Kind to be able to getImageRepository
as a client object.Enabled Sync, Suspend, and Resume buttons and checkboxes for the ImageRepositories table.
Added the ImageRepository CRD.
Added the SyncActions component with snapshot tests.
Added the SyncActions component on the Image Repository Details page.
Replaced Sync and Suspend/Resume UI elements on the Automation and Source details pages with the SyncActions component.