Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend/resume/reconcile Image Repositories #3831

Merged
merged 14 commits into from
Jul 25, 2023

Conversation

opudrovs
Copy link
Contributor

@opudrovs opudrovs commented Jul 9, 2023

Closes #3820
Closes #3821

  • Added explicit permissions for ImagePolicies, ImageRepositories, ImageUpdateAutomations to wego-admin-cluster-role.

  • Added ImageRepositoryAdapter to make ImageRepositories reconcilable in the UI.

  • Registered the ImageRepository Kind to be able to get ImageRepository as a client object.

  • Enabled Sync, Suspend, and Resume buttons and checkboxes for the ImageRepositories table.

  • Added the ImageRepository CRD.

  • Added the SyncActions component with snapshot tests.

  • Added the SyncActions component on the Image Repository Details page.

  • Replaced Sync and Suspend/Resume UI elements on the Automation and Source details pages with the SyncActions component.

@opudrovs opudrovs changed the title 3820 suspend resume reconcile image repositories Suspend/resume/reconcile Image Repositories Jul 9, 2023
@opudrovs opudrovs force-pushed the 3820-suspend-resume-reconcile-image-repositories branch 4 times, most recently from 3b9c2c2 to b5a9403 Compare July 9, 2023 21:38
@joshri joshri force-pushed the 3820-suspend-resume-reconcile-image-repositories branch from b5a9403 to 71c7056 Compare July 14, 2023 16:39
@opudrovs opudrovs force-pushed the 3820-suspend-resume-reconcile-image-repositories branch 11 times, most recently from 08e33df to 306b0d8 Compare July 25, 2023 00:23
@opudrovs opudrovs marked this pull request as ready for review July 25, 2023 01:27
@yiannistri yiannistri force-pushed the 3820-suspend-resume-reconcile-image-repositories branch from 564a74b to f7198f3 Compare July 25, 2023 09:12
@yiannistri yiannistri enabled auto-merge (rebase) July 25, 2023 11:16
@yiannistri yiannistri disabled auto-merge July 25, 2023 11:17
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend code looks fine 👌 @joshri can you please review the UI part?

Copy link
Contributor

@joshri joshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshri joshri merged commit 1356e22 into main Jul 25, 2023
26 checks passed
@joshri joshri deleted the 3820-suspend-resume-reconcile-image-repositories branch July 25, 2023 14:36
@chanwit chanwit added type/enhancement New feature or request area/ui Issues that require front-end work labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work type/enhancement New feature or request
Projects
None yet
4 participants