Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSSOM and related features #1999

Merged
merged 9 commits into from
Oct 28, 2024
Merged

Add CSSOM and related features #1999

merged 9 commits into from
Oct 28, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Oct 18, 2024 •
edited
Loading

api.CSSImportRule.supportsText remains in the draft, per supports.yml.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 18, 2024
@jamesnw jamesnw added question Further information is requested and removed question Further information is requested labels Oct 22, 2024
@jamesnw jamesnw marked this pull request as ready for review October 23, 2024 21:00
ddbeck
ddbeck approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way this looks. Suggesting some name and description tweaks, but I think this is ready to go once you've had a look over them.

features/alternative-style-sheets.yml Outdated Show resolved Hide resolved
features/css-escape.yml Outdated Show resolved Hide resolved
features/css-object-model.yml Outdated
@@ -0,0 +1,83 @@
name: CSS Object Model
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: CSS Object Model
name: CSS object model

features/css-object-model.yml Outdated Show resolved Hide resolved
features/get-computed-style.yml Outdated Show resolved Hide resolved
groups/cssom.yml Outdated Show resolved Hide resolved
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 28, 2024

When this (and/or #2000) lands, it'd be nice to file an issue to revisit this feature grouping after we've got full coverage of BCD. It'd be nice to know whether we need/want another model for this information (e.g., sharing keys, showing "dependent" feature relationships, etc.).

@jamesnw jamesnw mentioned this pull request Oct 28, 2024
Open
@jamesnw
Copy link
Collaborator Author

jamesnw commented Oct 28, 2024

When this (and/or #2000) lands, it'd be nice to file an issue to revisit this feature grouping after we've got full coverage of BCD. It'd be nice to know whether we need/want another model for this information (e.g., sharing keys, showing "dependent" feature relationships, etc.).

Opened #2094

@jamesnw jamesnw merged commit ecc7c3c into web-platform-dx:main Oct 28, 2024
3 checks passed
@jamesnw jamesnw deleted the cssom branch October 28, 2024 14:23
vwallen pushed a commit to oddbird/web-features that referenced this pull request Nov 5, 2024
@jamesnw @vwallen
Add CSSOM and related features (web-platform-dx#1999)
b4bd61b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesnw @ddbeck