New web app manifest features #2078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
reviewed
Nov 5, 2024
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
Co-authored-by: Daniel D. Beck <[email protected]>
ddbeck
reviewed
Nov 6, 2024
|
@ddbeck I think this is now about ready. The BCD changes have landed and we've got them here. There's a few more manifest-related features that can be created, but those can always be added later. |
ddbeck
approved these changes
Nov 14, 2024
Comment on lines
+45
to
+51
| # Used to install a web payment service worker on the fly, which is | ||
| # a separate feature. | ||
| # Ignored from compute_from for now. | ||
| - html.manifest.serviceworker | ||
| - html.manifest.serviceworker.scope | ||
| - html.manifest.serviceworker.src | ||
| - html.manifest.serviceworker.use_cache |
There was a problem hiding this comment.
Should these move to payment-handler.yml? If the answer is no, then you can go ahead and merge with this as-is.
There was a problem hiding this comment.
Rename → app-share-targets.yml (and fix up the dist too), for consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a complete list, but it's a good start.