Skip to content

Commit

Permalink
[wpt] Migrate custom-elements/ coverage to headless shell
Browse files Browse the repository at this point in the history
See [0] and [1] for background. The test history [2] and CQ flakiness
check suggest the tests consistently run as expected on the new runner
and embedder.

`ElementInternals-role.html` is marked as slow because each testdriver
call is now implemented as several WebDriver requests; collectively,
executing testdriver takes (~0.1s / call) * O(100 calls) = O(10s),
which easily exceeds the test timeout. (The timeout doesn't appear on
wpt.fyi because the results are generated from an official build,
which is heavily optimized.)

[0]: https://groups.google.com/a/chromium.org/g/blink-dev/c/JOu9l2hu1U8
[1]: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/run_web_platform_tests.md
[2]: https://ci.chromium.org/ui/p/chromium/test-search?q=headless_shell_wpt%2Fexternal%2Fwpt%2Fcustom-elements%2F

Bug: 40927590
Change-Id: I51107cc657fb859eb5bc682101c416f065dc2e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020549
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Auto-Submit: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1383210}
  • Loading branch information
jonathan-j-lee authored and chromium-wpt-export-bot committed Nov 14, 2024
1 parent 5f41a87 commit 498f2cd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions custom-elements/ElementInternals-role.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<!DOCTYPE HTML>
<!-- This test makes hundreds of sequential testdriver calls,
which can take a long time in non-optimized builds. -->
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
Expand Down

0 comments on commit 498f2cd

Please sign in to comment.