Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromium revision CI tests (DO NOT MERGE) #34652

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −5
Draft

Chromium revision CI tests (DO NOT MERGE) #34652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d305e8a
DO NOT MERGE: run `./wpt test-jobs --all` to see if it passes
foolip Dec 13, 2018
633c0cc
check candidate revision
DanielRyanSmith Jun 29, 2022
f19daae
Update browser.py
DanielRyanSmith Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
- script: |
set -eux -o pipefail
git fetch --depth 50 --quiet origin master
./wpt test-jobs | while read job; do
./wpt test-jobs --all | while read job; do
echo "$job"
echo "##vso[task.setvariable variable=$job;isOutput=true]true";
done
Expand Down
4 changes: 2 additions & 2 deletions tools/ci/ci_tools_unittest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ run_applicable_tox () {
export TOXENV="$OLD_TOXENV"
}

if ./wpt test-jobs --includes tools_unittest; then
if ./wpt test-jobs --all --includes tools_unittest; then
pip install --user -U tox
cd tools
run_applicable_tox
Expand All @@ -27,7 +27,7 @@ else
echo "Skipping tools unittest"
fi

if ./wpt test-jobs --includes wptrunner_unittest; then
if ./wpt test-jobs --all --includes wptrunner_unittest; then
cd tools/wptrunner
run_applicable_tox
cd $WPT_ROOT
Expand Down
4 changes: 2 additions & 2 deletions tools/wpt/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,10 +605,10 @@ def _get_latest_chromium_revision(self):

def _get_pinned_chromium_revision(self):
"""Returns the pinned Chromium revision number."""
return get("https://storage.googleapis.com/wpt-versions/pinned_chromium_revision").text.strip()
return get("https://storage.googleapis.com/wpt-versions/pinned_chromium_revision_NEW").text.strip()

def _get_chromium_revision(self, filename=None, version=None):
"""Retrieve a valid Chromium revision to download a browser component."""
"""Format a Chromium Snapshots URL to download a browser component."""

# If a specific version is passed as an argument, we will use it.
if version is not None:
Expand Down
Loading