WebNN: Add IDL and mojo definitions for logical[And|Or|Xor] operators
#48533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `logicalAnd`, `logicalOr`, and `logicalXor` operators are proposed by the WebNN WG [1]. These operators are required to support models that are commonly used. [1]: webmachinelearning/webnn#375 (comment) Bug: 368085623 Change-Id: I765e4f6787d01907c09e9c067426174a8f0cd240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5883679 Reviewed-by: Weizhong Xia <[email protected]> Reviewed-by: ningxin hu <[email protected]> Commit-Queue: Patrick To <[email protected]> Reviewed-by: Alex Gough <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365998}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5883679
branch
from
767a339
to
ed4ab5a
Compare
wpt-pr-bot
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
logicalAnd,logicalOr, andlogicalXoroperators are proposedby the WebNN WG 1. These operators are required to support models that
are commonly used.
Bug: 368085623
Change-Id: I765e4f6787d01907c09e9c067426174a8f0cd240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5883679
Reviewed-by: Weizhong Xia <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Patrick To <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1365998}