[testdriver] Add test_driver.bidi.permissions.set_permission
#49170
+132
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
testdriver.js
wptrunner
OrKoN
reviewed
Nov 14, 2024
infrastructure/metadata/infrastructure/webdriver/bidi/set_permission.https.html.ini
Outdated
Show resolved
Hide resolved
sadym-chromium
changed the title
test_driver.bidi.permissions.set_permissiontest_driver.bidi.permissions.set_permission
sadym-chromium
force-pushed
the
sadym/permissions
branch
from
bc22aab
to
134fc23
Compare
|
@OrKoN should the external specifications be stored in external |
I believe the external thing is specific to organizing tests of WebDriver BiDi in WPT. The classic permission spec was also external and it was not prefixed with external in neither classic tests tests nor in testdriver.js API. So, no, I do not think we need .external in testdriver.js. |
past
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
permissions.setPermissioncommand totest_driver.bidi.permissions.set_permission.RFC is not required, as the method matches a WebDriver BiDi command.