This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
Spring Boot Web3jSampleController #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksumic
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a
Web3jSampleRestController, which injects the already existingWeb3jSampleService, to be able to retrieve the client version by doing:Further, it refactors some field-based DI to constructor-based DI, to adhere to Spring best practices. And it adds a dependency on
spring-boot-starter-webto be able to run the web service.Where should the reviewer start?
Start at
Web3jSampleRestControllerTestas it covers the expected behavior. To test the changes manually, run an Ethereum client (e.g. Ganache) and go to http://localhost:8080/client/versionWhy is it needed?
Because it allows the user to start the Spring Boot application with an example REST endpoint, without having to write code; while keeping the example minimal