Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fabric 1.21.4 #4172

Open
wants to merge 1 commit into
base: v3.0
Choose a base branch
from
Open

Conversation

viloz1
Copy link

@viloz1 viloz1 commented Dec 5, 2024

As the title suggests. Would probably work to incorporate the same fixes into 1.21.3 as well. I have tested it for 1.24.4 and it seems to work.

I had to update the gradle version, and In turn update the loom version for all versions. Unsure of how this affects the other versions, that is not tested.

Changes

  • Updated to loom 1.9 for all versions
  • Upgraded to gradle to 8.11
  • In FabricMapChunkCache.java, use SerializedChunk.fromChunk to get nbt tag instead of the old removed serializer.
  • In DynmapPlugin.java, remove arguments from isOpaqueFullCube() and bs.isTransparent()

@I6FX
Copy link

I6FX commented Dec 9, 2024

You mentioned you tested it for 1.21.4, do you think you could share the compiled .jar? I'm having trouble getting it to work when I compile it on my own. Thanks!

@dammitcoetzee
Copy link

same would be nice to have jar. managed to compile, but also having trouble getting it to run. am very excited to have this!

@ChoosenMEME
Copy link

for me same, it doesnt start after a build. Server exits with the following errors.

[13:23:48] [main/ERROR]: Failed to start the minecraft server
java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'dynmap' at 'org.dynmap.fabric_1_21_4.DynmapMod'!
	at net.fabricmc.loader.impl.FabricLoaderImpl.lambda$invokeEntrypoints$2(FabricLoaderImpl.java:403) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:401) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.Hooks.startServer(Hooks.java:63) ~[fabric-loader-0.16.9.jar:?]
	at knot/net.minecraft.server.Main.main(Main.java:113) [server-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) [fabric-loader-0.16.9.jar:?]
	at net.fabricmc.installer.ServerLauncher.main(ServerLauncher.java:69) [fabric-1.21.4.jar:1.0.1]
Caused by: net.fabricmc.loader.api.EntrypointException: Exception while loading entries for entrypoint 'main' provided by 'dynmap'
	at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:56) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:399) ~[fabric-loader-0.16.9.jar:?]
	... 7 more
Caused by: net.fabricmc.loader.api.LanguageAdapterException: java.lang.ClassNotFoundException: org.dynmap.fabric_1_21_4.DynmapMod
	at net.fabricmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:52) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:124) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:53) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:399) ~[fabric-loader-0.16.9.jar:?]
	... 7 more
Caused by: java.lang.ClassNotFoundException: org.dynmap.fabric_1_21_4.DynmapMod
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[?:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) ~[fabric-loader-0.16.9.jar:?]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[?:?]
	at java.base/java.lang.Class.forName0(Native Method) ~[?:?]
	at java.base/java.lang.Class.forName(Class.java:534) ~[?:?]
	at java.base/java.lang.Class.forName(Class.java:513) ~[?:?]
	at net.fabricmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:50) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:124) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:53) ~[fabric-loader-0.16.9.jar:?]
	at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:399) ~[fabric-loader-0.16.9.jar:?]
	... 7 more

@ChimeraGaming
Copy link

Please update to 1.21.4 Fabric. Thanks!

@viloz1
Copy link
Author

viloz1 commented Dec 10, 2024

dynmap-1.21.4.zip

Here is a precompiled jar file. In order to compile it you need gradle v 8.11 installed. Are you using the most recent fabric-loader version in your servers?

@Dantevg
Copy link

Dantevg commented Dec 11, 2024

The mod fails to load because the package is still named org.dynmap.fabric_1_21 instead of org.dynmap.fabric_1_21_4, so the jar contains the folder fabric_1_21 while the entrypoint is set to org.dynmap.fabric_1_21_4.DynmapMod. Renaming the entrypoint in fabric.mod.json to org.dynmap.fabric_1_21.DynmapMod is a quick and dirty fix for the provided jar.

@viloz1
Copy link
Author

viloz1 commented Dec 11, 2024 via email

@dammitcoetzee
Copy link

thanks! will test if you can provide a new jar

@ChimeraGaming
Copy link

Any updates?

@dammitcoetzee
Copy link

dammitcoetzee commented Dec 18, 2024

image

Dynmap-3.7-beta-7-fabric-1.21.4_Dantevg_fix2.jar.zip

I applied the fix @Dantevg suggested and it is working on fabric 1.21.4. Jar attached. Will let you know if I have trouble and looking forward to the updated jar from @viloz1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants