-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fabric 1.21.4 #4172
base: v3.0
Are you sure you want to change the base?
Conversation
You mentioned you tested it for 1.21.4, do you think you could share the compiled .jar? I'm having trouble getting it to work when I compile it on my own. Thanks! |
same would be nice to have jar. managed to compile, but also having trouble getting it to run. am very excited to have this! |
for me same, it doesnt start after a build. Server exits with the following errors.
|
Please update to 1.21.4 Fabric. Thanks! |
Here is a precompiled jar file. In order to compile it you need gradle v 8.11 installed. Are you using the most recent fabric-loader version in your servers? |
The mod fails to load because the package is still named |
I realize this is because i forgot to push the latest changes, in which i
fixed this. Will push solution when able
Den ons 11 dec. 2024 17:47RedPolygon ***@***.***> skrev:
… The mod fails to load because the package is still named
org.dynmap.fabric_1_21 instead of org.dynmap.fabric_1_21_4, so the jar
contains the folder fabric_1_21 while the entrypoint is set to
org.dynmap.fabric_1_21_4.DynmapMod. Renaming the entrypoint in
fabric.mod.json to org.dynmap.fabric_1_21.DynmapMod is a quick and dirty
fix for the provided jar.
—
Reply to this email directly, view it on GitHub
<#4172 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANLNUDXJIZZV2QDVJGBBDQ32FBUCPAVCNFSM6AAAAABTDJTPOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZWGUZDONRWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
thanks! will test if you can provide a new jar |
Any updates? |
Dynmap-3.7-beta-7-fabric-1.21.4_Dantevg_fix2.jar.zip I applied the fix @Dantevg suggested and it is working on fabric 1.21.4. Jar attached. Will let you know if I have trouble and looking forward to the updated jar from @viloz1 |
As the title suggests. Would probably work to incorporate the same fixes into 1.21.3 as well. I have tested it for 1.24.4 and it seems to work.
I had to update the gradle version, and In turn update the loom version for all versions. Unsure of how this affects the other versions, that is not tested.
Changes
SerializedChunk.fromChunk
to get nbt tag instead of the old removed serializer.isOpaqueFullCube()
andbs.isTransparent()