[pull] develop from NLnetLabs:develop #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Address sanitizer options kindly provided by @noloader have been migrated to .github/workflows/testsuite.yml.
This addresses a couple issues found via #186.
Object files lack dependency on `config.h` symlink (and usually depend
only on `ldns/config.h`). As a result build occasionally fails in
`make --shuffe mode`:
$ make --shuffle
...
./libtool --tag=CC --quiet --mode=compile gcc -I. -I. \
-DHAVE_CONFIG_H -DLDNS_TRUST_ANCHOR_FILE="\"...-dns-root-data-2019-01-11/root.key\"" \
-DOPENSSL_API_COMPAT=10100 -fno-strict-aliasing -Wunused-function -Wstrict-prototypes \
-Wwrite-strings -W -Wall -g -O2 -I...-openssl-3.0.7-dev/include -c examples/ldns-rrsig.c \
-o examples/ldns-rrsig.o
examples/ldns-rrsig.c:10:10: fatal error: config.h: No such file or directory
10 | #include "config.h"
| ^~~~~~~~~~
The change moves `config.h` symlink creation in `setup-builddir` from
a dependency on final binary to dependency on all individual objects.
While at it regenerated dependencies with `make depend`.
before the change `make --shuffle` build was failing in about 50% cases.
After the change: `make --shuffle` succeeded 80 times in a row.
This is needed for macOS CI testing.
Rather than adding \000 to an existing label, add a new label "\000." to the start of the domain name, to find the closes next possible domain name.
$OSTYPE under FreeBSD is “FreeBSD”, which doesn’t match “*bsd*”. This updates the test to accommodate that capitalization variance.
This adds a copy of the function prototypes for internal functions where necessary. It effectively works around the following compilation error: error: no previous prototype for function [-Werror,-Wmissing-prototypes] Tested on FreeBSD/amd64 (14.0-CURRENT).
With -Wstrict-prototypes clang warns that "a function declaration without a prototype is deprecated in all versions of C."
libressl >= 3.8.1 removed ENGINE support:
"ENGINE support was removed and OPENSSL_NO_ENGINE is set. In spite
of this, some stub functions are provided to avoid patching some
applications that do not honor OPENSSL_NO_ENGINE."
resulting in the following build failure with gost:
./keys.c:167:35: error: 'ENGINE_METHOD_ALL' undeclared (first use in this function)
167 | if(!ENGINE_set_default(e, ENGINE_METHOD_ALL)) {
| ^~~~~~~~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/37cc05b78a7004caa1b45d896121f059a4f8ca00
Signed-off-by: Fabrice Fontaine <[email protected]>
SWIG_Python_str_AsChar needs to be replaced by SWIG_PyUnicode_AsUTF8AndSize See swig/swig@f89dd59
The replacement, SWIG_PyUnicode_AsUTF8AndSize, has different memory management requirements.
The ssize_t type can be int instead of long, and the pointer types are incompatible.
This change ignores several files which are generated by autotools, et al. Signed-off-by: Enji Cooper <[email protected]>
Signed-off-by: Enji Cooper <[email protected]>
Prior to this change `dsasig` was not freed when calling `DSA_SIG_set0` failed. Free `dsasig` on error in that code path now. Reported by: Coverity Signed-off-by: Enji Cooper <[email protected]>
Both `i` and `n` should match the return type for `sk_X509_num` (which is `int`, not `size_t`). This addresses a potential issue where `sk_X509_num(..)` could return -1, resulting in an unnecessary number of loop iterations and undesirable behavior. Reported by: Coverity Signed-off-by: Enji Cooper <[email protected]>
Address several issues with the ultimate goal being to fix Coverity cited problems
32-bit compatibility for Python SWIG bindings
ldns: fix the build in FreeBSD's base system
improve 'next-label' algorithm in ldns-walk
Add functions to extract RFC 8914 extended errors
Expand CI: Cygwin, BSDs, musl libc, 32-bit, and big-endian
and a small dereferencing void * fix
Enable testing in macOS CI
And the BSD's don't like sudo
Makefile.in: build config.h before any object
16-unit-tests-edns: Fix leak & warnings
Remove unused CI recipes and extend GitHub workflow
Still zome left in ldns-verify-zone, but leaving it for now
Because it broke make
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )