Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try testing in container #816

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

virzak
Copy link
Contributor

@virzak virzak commented Feb 19, 2024

No description provided.

@virzak
Copy link
Contributor Author

virzak commented Feb 27, 2024

Hi @coolaj86,

Could you please approve the workflow?

@virzak
Copy link
Contributor Author

virzak commented Apr 1, 2024

Hi @coolaj86.
Hi @coolaj86,

Could you please approve the workflow?

@coolaj86 coolaj86 marked this pull request as ready for review May 16, 2024 20:40
@coolaj86
Copy link
Member

Hi @virzak,

Thanks for looking into this. I'm now available to focus on Webi during the next 2-3 weeks. If you're also available, I'll have a quick turn around time to work with you on this.

@virzak
Copy link
Contributor Author

virzak commented May 16, 2024

@coolaj86 let's do it!

@coolaj86
Copy link
Member

It looks like what you have here is simply creating a container, copying a curl binary into it, and then running webi on the fresh system to see if it installs pwsh.

Where do you want to take it?

I think my ideal would be something like:

  • not run on every push, but must be run before any ref: or feat: PR can be accepted
    (GitHub Actions is distractingly slow to have run on each commit)
  • track which things are expected to not work on Alpine, or macOS, or Windows
  • check the -V / --version of each thing as the last step

I also have a High-Availability Proxmox cluster where I can create LXCs within a matter of a few seconds (I could even preallocate some), and delete them just as easily. That could be much faster than GitHub Actions, and give access to any environment... but also comes at the cost of development.

@virzak
Copy link
Contributor Author

virzak commented May 17, 2024

This was just a first investigation step. The intention was to expose #814 during build.

Since this workflow was just recently approved I didn't know how long this would take. It also looks like curl needs more permissions, so I'll try to modify it.

Definitely if it takes too long, perhaps there needs to be a different strategy.

@virzak virzak force-pushed the test-in-container branch 3 times, most recently from c291235 to 7cd7f15 Compare May 17, 2024 12:10
@virzak
Copy link
Contributor Author

virzak commented May 17, 2024

After fixing the permission issue, the container seems to be taking about 5-6 seconds.
It currently fails because it uses the production webi, which still has the #814 bug, so it needs to be adjusted to use webi produced in this build.

@coolaj86
Copy link
Member

Try installing 7.3 instead of latest / 7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants