Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the implementation of DML backend and disable CI #288

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

mingmingtasd
Copy link
Collaborator

No description provided.

@mingmingtasd
Copy link
Collaborator Author

PTAL, I will rebase PR #287 on this. @fujunwei @bbernhar

@@ -218,8 +218,6 @@ source_set("sources") {
"dml/ContextDML.h",
"dml/GraphDML.cpp",
"dml/GraphDML.h",
"dml/DMLUtils.cpp",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete all the files in the sources and then add them piece by piece.

@mingmingtasd mingmingtasd force-pushed the dml_delete branch 3 times, most recently from a59c230 to aa8dbd3 Compare August 4, 2022 08:27
Copy link
Collaborator

@fujunwei fujunwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge it.

@fujunwei fujunwei merged commit c826c65 into webmachinelearning:main Aug 5, 2022
@BruceDai
Copy link
Collaborator

@mingmingtasd Please also update README.md by removing DML information from CI status table, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants