Fixed issues introduced by PR-228 (#230)

- buildConstantByNpy should have a default vaule for new parameter - Fixed typo in ssd_mobilenetv1_nchw.js
webmachinelearning · May 6, 2024 · 3ce8c0d · 3ce8c0d
1 parent a3ef74d
commit 3ce8c0d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/utils.js b/common/utils.js
@@ -84,7 +84,7 @@ export const toHalf = (function() {
 
 // Convert npy data in original data type to `targetType`, only support
 // 'float32' to 'float16' conversion currently.
-export async function buildConstantByNpy(builder, url, targetType) {
+export async function buildConstantByNpy(builder, url, targetType = 'float32') {
   const dataTypeMap = new Map([
     ['f2', {type: 'float16', array: Uint16Array}],
     ['f4', {type: 'float32', array: Float32Array}],

diff --git a/object_detection/ssd_mobilenetv1_nchw.js b/object_detection/ssd_mobilenetv1_nchw.js
@@ -262,7 +262,7 @@ ${nameArray[1]}_BatchNorm_batchnorm`;
 
     if (this.targetDataType_ === 'float16') {
       boxes = this.builder_.cast(boxes, 'float32');
-      scores = this.builder_.cast(boxes, 'float32');
+      scores = this.builder_.cast(scores, 'float32');
     }
     return {boxes, scores};
   }