Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace devicePreference as deviceType #185

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Replace devicePreference as deviceType #185

merged 1 commit into from
Nov 2, 2023

Conversation

Honry
Copy link
Collaborator

@Honry Honry commented Oct 30, 2023

As the implementation will soon support the MLDeviceType enum.

@Honry
Replace devicePreference as deviceType
69538ad 
As the implementation will soon support the MLDeviceType enum.
@Honry Honry requested a review from huningxin October 30, 2023 06:03
@Honry
Copy link
Collaborator Author

Honry commented Oct 30, 2023 •
edited
Loading

@huningxin, @BruceDai, PTAL, thanks!

@BruceDai
Copy link
Contributor

LGTM, thanks.

huningxin
huningxin approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Honry Honry merged commit b138e20 into webmachinelearning:master Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @BruceDai @huningxin