-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable WebNN CPU for LeNet #204
Merged
Honry
merged 2 commits into
webmachinelearning:master
from
ibelem:disable-webnn-cpu-for-lenet
Mar 25, 2024
Merged
Disable WebNN CPU for LeNet #204
Honry
merged 2 commits into
webmachinelearning:master
from
ibelem:disable-webnn-cpu-for-lenet
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honry
reviewed
Mar 25, 2024
Comment out WebNN CPU backend until there is NCHW layout by transpose for LeNet. @Honry PTAL |
Honry
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
huningxin
added a commit
to huningxin/webnn-samples
that referenced
this pull request
Mar 25, 2024
This reverts commit cc9559c.
Honry
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Revert "Disable WebNN CPU for LeNet (#204)" This reverts commit cc9559c. * Support CPU backend for LeNet sample The changes of this PR include: 1. Support nhwc conv2d and pool2d for LeNet. 2. Derive permuteData function from transformers.js that is used to permute the filter data. 3. Use gemm to replace matmul, because XNNPACK matmul doesn't support 2D inputs. 4. Fix some isses of UI.
Honry
pushed a commit
to Honry/webnn-samples
that referenced
this pull request
May 15, 2024
* Disable WebNN CPU for LeNet * Comment out WebNN CPU backend until there is NCHW layout by transpose
Honry
pushed a commit
to Honry/webnn-samples
that referenced
this pull request
May 15, 2024
* Revert "Disable WebNN CPU for LeNet (webmachinelearning#204)" This reverts commit cc9559c. * Support CPU backend for LeNet sample The changes of this PR include: 1. Support nhwc conv2d and pool2d for LeNet. 2. Derive permuteData function from transformers.js that is used to permute the filter data. 3. Use gemm to replace matmul, because XNNPACK matmul doesn't support 2D inputs. 4. Fix some isses of UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no lenet_nchw weights files under https://github.com/webmachinelearning/test-data/tree/main/models . Disable "WebNN CPU" in WebNN Samples.
@huningxin @Honry PTAL