Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for running WebNN NPU #232

Merged
merged 11 commits into from
Aug 30, 2024

Conversation

mingmingtasd
Copy link
Contributor

PTAL, thanks! @Honry @huningxin @ibelem

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Edge browser will download the latest DirectML.dll automatically when WebNN is enabled.
3. Launch your browser in Windows Command Line:
* For Google Chrome Canary:
> "C:\Users\\"username"\AppData\Local\Google\Chrome SxS\Application\chrome.exe" --disable-gpu-sandbox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huningxin @mingmingtasd Do we have to use the '--disable-gpu-sandbox' flag? I mean the minimal impact flag the better, only use "--use-redist-dml" will not help, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use "--use-redist-dml" is OK for chrome canary. I also removed the flag for edge canary, is that OK? Should rely on edge itself to download the latest dml?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to use the '--disable-gpu-sandbox' flag?

Interesting, a new flag to add to the list. I suppose that's a narrower form of --no-sandbox that only applies to the GPU process.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ibelem
Copy link
Contributor

ibelem commented May 8, 2024

@huningxin @Honry do you have any comments for merging this PR? Thanks

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mingmingtasd
Copy link
Contributor Author

Upload a new commit, PTAL, thanks! @ibelem @Honry @huningxin

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mingmingtasd
Copy link
Contributor Author

Updated to address your comments, PTAL again, thanks! @huningxin

Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two minor comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@huningxin huningxin merged commit 5366a4e into webmachinelearning:master Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants