Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated MLOperandDescriptor.type #240

Merged
merged 1 commit into from
May 23, 2024

Conversation

Honry
Copy link
Collaborator

@Honry Honry commented May 23, 2024

Now latest Chrome has supported MLOperandDescriptor.dataType, we can remove deprecated MLOperandDescriptor.type.

Now latest Chrome has supported latest MLOperandDescriptor.dataType,
we can remove deprecated MLOperandDescriptor.type.
@Honry
Copy link
Collaborator Author

Honry commented May 23, 2024

@ibelem, @huningxin, PTAL, thanks!

cc/ @BruceDai, you may want to remove it from webnn-polyfill as well.

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Honry Honry merged commit fce75fa into webmachinelearning:master May 23, 2024
3 checks passed
@BruceDai
Copy link
Contributor

cc/ @BruceDai, you may want to remove it from webnn-polyfill as well.

Thanks for kindly reminder. 👍
WebNN Polyfill API has already supported MLOperandDescriptor.dataType since webmachinelearning/webnn-polyfill#238 was landed.

@Honry
Copy link
Collaborator Author

Honry commented May 23, 2024

cc/ @BruceDai, you may want to remove it from webnn-polyfill as well.

Thanks for kindly reminder. 👍 WebNN Polyfill API has already supported MLOperandDescriptor.dataType since webmachinelearning/webnn-polyfill#238 was landed.

I mean removing the old MLOperandDescriptor.type. Oh, so remaining the WPT tests I think.

@BruceDai
Copy link
Contributor

Right. I will submit PR to fix it on WPT side. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants