Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify reduction with empty axes and scalar input #741

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Clarify reduction with empty axes and scalar input #741

merged 12 commits into from
Jul 30, 2024

Commits on Jul 24, 2024

  1. Editorial: Clarify reduction with empty axes and scalar input 

    Improve the description of the reduction ops:

- Give in-line definition for L1/L2.
- Make "input values" slightly clearer.
- Explicitly note that if the input is a scalar, so is the output.
- State how the reduction function is applied for empty axes.
- Standardize on "reduction operation" not "reduce operation".

Fixes webmachinelearning#740
    @inexorabletash
    inexorabletash committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7506d55 View commit details
    Browse the repository at this point in the history

  2. Make "reduction types" list normative 

    The "reduction types" list was styled as a non-normative note. The
element-wise ops (add, equal, abs, etc.) don't do this. Be consistent
here.
    @inexorabletash
    inexorabletash committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5a2df45 View commit details
    Browse the repository at this point in the history

  3. One more wording tweak

    @inexorabletash
    inexorabletash committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fc04fcf View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. more explicit input values

    @inexorabletash
    inexorabletash committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7fbceaa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/review' into reduction-reword

    @inexorabletash
    inexorabletash committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e0bda19 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Merge branch 'refs/heads/review' into reduction-reword

    @inexorabletash
    inexorabletash committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    15349c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Extra space

    @fdwr
    fdwr authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4af5b3c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refs/heads/review' into reduction-reword

    @inexorabletash
    inexorabletash committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    cb6e70d View commit details
    Browse the repository at this point in the history

  3. don't repeat "input", "values" 

    Co-authored-by: Dwayne Robinson <[email protected]>
    @inexorabletash @fdwr
    inexorabletash and fdwr authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c14dc6a View commit details
    Browse the repository at this point in the history

  4. more commas more better 

    Co-authored-by: Dwayne Robinson <[email protected]>
    @inexorabletash @fdwr
    inexorabletash and fdwr authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d798044 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'mine/reduction-reword' into reduction-r… 

    …eword
    @inexorabletash
    inexorabletash committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f7eb68e View commit details
    Browse the repository at this point in the history

  6. remove 'all'

    @inexorabletash
    inexorabletash committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f982418 View commit details
    Browse the repository at this point in the history