Include output operand type/rank in op constraint tables #789
+323
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not referenced normatively, but helpful at-a-glance information. This should be redundant with existing per-op documentation.
|
@fdwr is this about what you were thinking? |
fdwr
reviewed
Nov 16, 2024
Co-authored-by: Dwayne Robinson <[email protected]>
|
@fdwr - one more look? I think we crossed the streams and you reviewed just before my last commit went in. |
huningxin
reviewed
Nov 19, 2024
| <tr> | ||
| <td>*output*</td> | ||
| <td>[=/same type as|same as=] {{trueValue}}</td> | ||
| <td>maximum of {{trueValue}}'s [=MLOperand/rank=] and {{falseValue}}'s [=MLOperand/rank=]</td> |
There was a problem hiding this comment.
condition's rank should also be included according to the algorithm step
1. Set |outputShape| to the result of [=bidirectionally broadcasting=] |condition|'s [=MLOperand/shape=] and |outputShape].
BTW, there is a typo of "|outputShape]" in the algorithm step, it should be "|outputShape|".
Suggested change
| <td>maximum of {{trueValue}}'s [=MLOperand/rank=] and {{falseValue}}'s [=MLOperand/rank=]</td> | |
| <td>maximum of {{condition}}'s [=MLOperand/rank=], {{trueValue}}'s [=MLOperand/rank=] and {{falseValue}}'s [=MLOperand/rank=]</td> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not referenced normatively, but helpful at-a-glance information. This should be redundant with existing per-op documentation.
As discussed in #657 (comment)
Preview | Diff