Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Remove-Constraint-Warnings #72

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/Remove-Constraint-Warnings #72

wants to merge 3 commits into from

Conversation

KhoiKy
Copy link
Contributor

@KhoiKy KhoiKy commented Oct 22, 2023

  • Verified that there are tests where the constraint names are explicitly defined.

@KhoiKy KhoiKy requested a review from a team as a code owner October 22, 2023 19:43
splatteredbits
splatteredbits requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@splatteredbits splatteredbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to remove the actual warnings. They need to stay. We need to figure out why, with our plug-ins, the warnings are getting written at all. They shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splatteredbits splatteredbits splatteredbits requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhoiKy @splatteredbits