Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now twilio is no longer being used, consider trying to go fully static? #219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

willstott101
Copy link
Contributor

@willstott101 willstott101 commented Mar 14, 2020

Whilst trying to understand this project I realised that the back-end actually doesn't do anything at all.

Making a change like this would vastly simplify the project as a whole, and (in my opinion) make it easier to re-host and contribute to. Potentially even committing __rtcConfig__.json would allow PRs to be hosted on github pages and the like.

I'd understand if you wanted to keep the potential flexibility (especially if twilio don't provide any other method of getting ICE details), but thought I'd make this PR regardless.

@willstott101
Copy link
Contributor Author

willstott101 commented Mar 14, 2020

Obviously I had to guess what secret-download, secret-upload and (the untested) nginx.conf might look like. But I added the Caddyfile I was using for testing for good measure.

@feross
Copy link
Member

feross commented May 12, 2020

Thanks for the PR. Agree that going static would simplify this. Will consider it when I have more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants