Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logs): dumped logs while running #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(logs): dumped logs while running #45

wants to merge 1 commit into from

Conversation

Kiyo5hi
Copy link
Contributor

@Kiyo5hi Kiyo5hi commented Aug 29, 2023 •
edited
Loading

Screenshot 2023-08-29 at 3 04 35 PM

@praxxus11
Copy link

lgtm!

praxxus11
praxxus11 approved these changes Dec 2, 2023
View reviewed changes
pkg/ui/naive/events.go
@@ -77,6 +89,8 @@ func (u UI) registerEvents() {
log.Error(err)
}
case <-finishedCh:
stdoutFile.Close()
stderrFile.Close()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praxxus11 praxxus11 praxxus11 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kiyo5hi @praxxus11