New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly spell out fallback element input type #189

Open

barbeque wants to merge 5 commits into weixiyen:master from barbeque:patch-1

barbeque commented Jun 25, 2019

I didn't quite understand that this had to be a type="file" input element and I had to read the filedrop source code to figure it out.

If this is helpful, I could also create a pull request to throw an error on filedrop initialization if the fallback element is not of type file.

barbeque added 5 commits

June 25, 2019 10:35


          Explicitly spell out fallback element input type

ac1f231


          Make fallback_id optional

bb99079


          File type sanity checking


          Merge branch 'master' into patch-1

c855f96


          No longer raise errors if fallback_id is unset

648573e

Author

barbeque commented Jun 26, 2019

I've gone ahead and made the following changes that I mentioned in the original post:

Errors will no longer be raised when the fallback_id is unset
If the fallback_id is set and the target element is not an input[type=file], it will raise an error: Fallback element [upload_button] must be of type 'file', but it is of 'button'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet