More early termination problems #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
force-pushed
the
edsko/another-early-termination-bug
branch
from
cc62950
to
f11ace2
Compare
edsko
changed the title
edsko
force-pushed
the
edsko/another-early-termination-bug
branch
4 times, most recently
from
2b34b4a
to
a489e29
Compare
Turns out, the grapesy test suite is Too Powerful and has in fact revealed an STM bug 😱 See `atomically` for details.
edsko
force-pushed
the
edsko/another-early-termination-bug
branch
from
a489e29
to
882a0dd
Compare
See introduction of `skipMissedStep`; specifically, the problem was that `ourStep` did not distinguish between aggressive mode and conservative mode (effectively, it assumed aggressive mode always). This resolves a deadlock in the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.