Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #83: Better API for libclang command line arguments #98

Closed
wants to merge 1 commit into from

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Aug 19, 2024

Technically this solves #83, as nothing breaks.

I think we should have some tests first. tasty-golden seems like a good idea.

@phadej phadej requested a review from edsko August 19, 2024 15:17
@edsko
Copy link
Collaborator

edsko commented Aug 22, 2024

Stretching the definition of "technically solves" here 😬 Agreed that starting on a test harness is useful. Perhaps an initial way (and most important) to actually use the command line arguments is to configure a target platform. One thing that this should affect is the sizeof and alignof fields of the parsed structs.

@edsko
Copy link
Collaborator

edsko commented Oct 1, 2024

Obsoleted by #196, which takes a first step towards defining a record type for ClangArgs (by no means exhaustive).

@edsko edsko closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants