Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGAGE-1756] - Integration Widget VTEX #167

Merged
merged 28 commits into from
Oct 17, 2024

Conversation

MarcusviniciusLsantos
Copy link
Contributor

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

  • Integration with mocks

Summary of Changes

  • adjust logic to render widgets and drawers

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 13.70968% with 107 lines in your changes missing coverage. Please review.

Project coverage is 18.57%. Comparing base (51a8285) to head (e94b8b1).

Files with missing lines Patch % Lines
src/components/insights/widgets/DynamicWidget.vue 0.00% 30 Missing ⚠️
src/components/insights/cards/CardVtexOrder.vue 30.00% 21 Missing ⚠️
...nts/insights/drawers/DrawerConfigWidgetDynamic.vue 0.00% 20 Missing ⚠️
...nents/insights/drawers/DrawerConfigContentVtex.vue 11.76% 15 Missing ⚠️
src/store/modules/widgets.ts 0.00% 14 Missing ⚠️
src/components/ModalResetWidget.vue 0.00% 4 Missing ⚠️
...nts/insights/drawers/DrawerConfigGallery/index.vue 0.00% 2 Missing ⚠️
src/components/insights/cards/CardEmpty.vue 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/widget-vtex     #167      +/-   ##
=======================================================
- Coverage                18.68%   18.57%   -0.11%     
=======================================================
  Files                      110      114       +4     
  Lines                     2473     2579     +106     
  Branches                   570      602      +32     
=======================================================
+ Hits                       462      479      +17     
- Misses                    2011     2100      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcusviniciusLsantos MarcusviniciusLsantos changed the base branch from main to feature/widget-vtex October 17, 2024 18:41
@MarcusviniciusLsantos MarcusviniciusLsantos marked this pull request as ready for review October 17, 2024 18:52
@MarcusviniciusLsantos MarcusviniciusLsantos merged commit b59ba3a into feature/widget-vtex Oct 17, 2024
1 check passed
@MarcusviniciusLsantos MarcusviniciusLsantos deleted the feature/new-widgets-vtex branch October 17, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants