Refactor: Using Kafka instead of RabbitMQ #33
+202
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
编写函数已经过验证 |
|
Kafka的日志管理同样可以利用EsHook，而且可以区分正常的Logger与ErrLogger，我在想我们是否需要这个。 |
ozline
requested changes
Oct 16, 2024
ok |
SchwarzSail
reviewed
Oct 18, 2024
pkg/kafka/kafka.go
Outdated
|
感觉也可以合掉了 |
|
已经解决了conflicts |
ozline
requested review from
jiuxia211 and
ozline
and removed request for
ozline
ozline
reviewed
Oct 18, 2024
| KAFKA_CFG_ADVERTISED_LISTENERS=BROKER://fzuhelper-kafka:9092,EXTERNAL://127.0.0.1:9093 | ||
| KAFKA_CFG_INTER_BROKER_LISTENER_NAME=BROKER | ||
| [email protected]:9094 | ||
| ALLOW_PLAINTEXT_LISTEN |
ozline
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Kafka instead of RabbitMQ
Refs: #30