Add hf_converter keyword to SpectrumDataset._to_tensor and AnnotatedSpectrumDataset._to_tensor for pylance compatability.
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of pinning to a very specific Lance version, the better solution is actually to add the |
|
Sounds good, I added to |
Lilferrit
changed the title
hf_converter keyword to SpectrumDataset._to_tensor and AnnotatedSpectrumDataset._to_tensor for pylance compatability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the error in #67. I tested this fix in the
dev_latest_depthchargebranch of the Casanovo repo by installing the package directly from GitHub and it worked there as well. All of the depthcharge unit tests passed on my local machine with pylance v0.15.0.