Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with ga, gsp & gcf with git 2.25.1 #335

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

sandr01d
Copy link
Collaborator

@sandr01d sandr01d commented Jan 26, 2024

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

We're currently using --pathspec-file-nul in ga, gsp and gcf. This option is not available in older versions of git, such as the current release in the Ubuntu repositories (2.25.1). This PR removes the usage of --pathspec-file-nul in favor of storing the file names passed to the git command in an array instead of a string.
This PR is based on #326. I will rebase and mark it as ready for review, once #326 is merged.

Fixes #328

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

@sandr01d sandr01d marked this pull request as ready for review March 24, 2024 15:59
Copy link
Collaborator

@carlfriedrich carlfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@sandr01d sandr01d merged commit 1c34d0d into wfxr:master Apr 9, 2024
4 checks passed
@sandr01d sandr01d deleted the fix-old-git branch April 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forgit::stash::push failing with error: unknown option `pathspec-file-nul'
3 participants