Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set iframe lazy load resumption steps to null on navigation #10226

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Mar 26, 2024

When an iframe element is navigated, the lazy-loading mechanism should not navigate it again.

Fixes #10213.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )

When an iframe element is navigated, the lazy-loading mechanism should not navigate it again.

Fixes #10213.
@domenic domenic requested a review from domfarolino March 28, 2024 01:28
@domfarolino
Copy link
Member

So spec-wise this looks fine, but I think there is an outstanding question about what other non-Chromium browsers do in this case, and if we have any existing WPTs for this scenario (#10213 (comment)). I presume you're still investigating that side of things?

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Apr 10, 2024
@zcorpan
Copy link
Member Author

zcorpan commented Apr 10, 2024

Tests at web-platform-tests/wpt#45650

Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting this comment to clear my "open review requests" until tests are landed. Can you request my review once those are in?

@zcorpan zcorpan requested a review from domfarolino June 18, 2024 16:08
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Jun 18, 2024
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

source Outdated Show resolved Hide resolved
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 24, 2024
… a=testonly

Automatic update from web-platform-tests
HTML: navigate cancels iframe lazy-load

See whatwg/html#10226
--

wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed
wpt-pr: 45650
@zcorpan zcorpan merged commit 91b0398 into main Jun 25, 2024
2 checks passed
@zcorpan zcorpan deleted the zcorpan/nav-lazy-iframe branch June 25, 2024 00:45
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jun 25, 2024
… a=testonly

Automatic update from web-platform-tests
HTML: navigate cancels iframe lazy-load

See whatwg/html#10226
--

wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed
wpt-pr: 45650
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Jun 27, 2024
… a=testonly

Automatic update from web-platform-tests
HTML: navigate cancels iframe lazy-load

See whatwg/html#10226
--

wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed
wpt-pr: 45650
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jul 1, 2024
… a=testonly

Automatic update from web-platform-tests
HTML: navigate cancels iframe lazy-load

See whatwg/html#10226
--

wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed
wpt-pr: 45650

UltraBlame original commit: 336f2800e314e6af9a0c72e08a445389939024a5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jul 1, 2024
… a=testonly

Automatic update from web-platform-tests
HTML: navigate cancels iframe lazy-load

See whatwg/html#10226
--

wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed
wpt-pr: 45650

UltraBlame original commit: 336f2800e314e6af9a0c72e08a445389939024a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Web compat: Navigating a lazy-loading iframe with location.replace
2 participants