-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set iframe lazy load resumption steps to null on navigation #10226
Conversation
When an iframe element is navigated, the lazy-loading mechanism should not navigate it again. Fixes #10213.
So spec-wise this looks fine, but I think there is an outstanding question about what other non-Chromium browsers do in this case, and if we have any existing WPTs for this scenario (#10213 (comment)). I presume you're still investigating that side of things? |
Tests at web-platform-tests/wpt#45650 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting this comment to clear my "open review requests" until tests are landed. Can you request my review once those are in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… a=testonly Automatic update from web-platform-tests HTML: navigate cancels iframe lazy-load See whatwg/html#10226 -- wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed wpt-pr: 45650
… a=testonly Automatic update from web-platform-tests HTML: navigate cancels iframe lazy-load See whatwg/html#10226 -- wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed wpt-pr: 45650
… a=testonly Automatic update from web-platform-tests HTML: navigate cancels iframe lazy-load See whatwg/html#10226 -- wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed wpt-pr: 45650
… a=testonly Automatic update from web-platform-tests HTML: navigate cancels iframe lazy-load See whatwg/html#10226 -- wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed wpt-pr: 45650 UltraBlame original commit: 336f2800e314e6af9a0c72e08a445389939024a5
… a=testonly Automatic update from web-platform-tests HTML: navigate cancels iframe lazy-load See whatwg/html#10226 -- wpt-commits: e916af8e223ce2ea5705063ef8ed021e4ad6c3ed wpt-pr: 45650 UltraBlame original commit: 336f2800e314e6af9a0c72e08a445389939024a5
When an iframe element is navigated, the lazy-loading mechanism should not navigate it again.
Fixes #10213.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )