Switch to attachments v4 #330
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubdos
reviewed
Oct 14, 2024
Comment on lines
580
to
582
| async fn post_to_cdn0<'s, C: std::io::Read + Send + 's>( | ||
| &mut self, | ||
| cdn_id: u32, |
There was a problem hiding this comment.
Suggested change
| async fn post_to_cdn0<'s, C: std::io::Read + Send + 's>( | |
| &mut self, | |
| cdn_id: u32, | |
| async fn post_to_cdn<'s, C: std::io::Read + Send + 's>( | |
| &mut self, | |
| cdn_id: u32, |
There was a problem hiding this comment.
(We probably want to retain upload capability to cdn0 for profile pics etc?)
rubdos
reviewed
Oct 14, 2024
Comment on lines
445
to
452
| #[tracing::instrument(skip(self))] | ||
| async fn post( | ||
| &mut self, | ||
| service: Endpoint, | ||
| path: &str, | ||
| additional_headers: &[(&str, &str)], | ||
| credentials_override: HttpAuthOverride, | ||
| ) -> Result<HashMap<String, String>, ServiceError> { |
There was a problem hiding this comment.
yes 😁 don't shoot the messenger implementer
There was a problem hiding this comment.
In that case maybe
Suggested change
| #[tracing::instrument(skip(self))] | |
| async fn post( | |
| &mut self, | |
| service: Endpoint, | |
| path: &str, | |
| additional_headers: &[(&str, &str)], | |
| credentials_override: HttpAuthOverride, | |
| ) -> Result<HashMap<String, String>, ServiceError> { | |
| #[tracing::instrument(skip(self))] | |
| async fn post_empty_body( | |
| &mut self, | |
| service: Endpoint, | |
| path: &str, | |
| additional_headers: &[(&str, &str)], | |
| credentials_override: HttpAuthOverride, | |
| ) -> Result<HashMap<String, String>, ServiceError> { |
just for clarity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which means dropping CDN0 which was AWS CloudFront and use CDN2 or CDN3 depending on what the server tells us to do.
TODO:
post_to_cdn0functional, even though I'm not sure whether it is used or not.In general, I'd like to ditch
libsignal-service-actixsince it is not used anymore, which in turn will let us remove thePushServicetrait and let us have a much nicer direct access to the HTTP API.Closes #320