Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update population_rank #59

Closed

Conversation

@nvkelso
Copy link
Member

nvkelso commented Aug 21, 2019

Thanks for pointing that out, we should fix it! The original list was focused on locality only, the new list includes other placetypes like country.

I suspect this is because the Makefile needs to be updated with docs targets, looks like those are MIA now. Generally we use a build process to gather content from other repos instead of manually editing the docs here.

@pathmapper
Copy link
Author

pathmapper commented Aug 21, 2019

@nvkelso thanks, so closing here and open an issue instead, right?

Sorry, should have read https://github.com/whosonfirst/whosonfirst-www#example-editing-a-page-from-github

@nvkelso
Copy link
Member

nvkelso commented Aug 21, 2019

Yes, closing in favor of #60.

@nvkelso nvkelso closed this Aug 21, 2019
@pathmapper pathmapper deleted the update_population_rank branch August 22, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants