Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds performance insights to Postgres template #489

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

O5m4r
Copy link

@O5m4r O5m4r commented Sep 11, 2020

  • yamllint state/rds-postgres.yaml
  • cfn-lint -i E1019 E3002 E2520 -t state/rds-postgres.yaml
  • aws cloudformation validate-template --template-body file://state/rds-postgres.yaml

Added parameters to optionally have performance insights in Postgres RDS, and custom amount of retention days in it.

@michaelwittig
Copy link
Contributor

@andreaswittig could you check the defaults? Is it a good idea to enable by default or will this break existing setups with small instances? Not sure if we should get rid of PerformanceInsights and turn off if PerformanceInsightsRetentionPeriod is set to zero.

@andreaswittig
Copy link
Contributor

@O5m4r Thanks a lot for your contribution.

Your solution is very flexible but comes with the disadvantage, that setting PerformanceInsight to true will fail for some instance types.

I took a different approach for the wordpress/wordpress-ha template. My idea was to enable RDS Performance Insights for all supported instance types out of the box. See #490. What do you think?

@O5m4r
Copy link
Author

O5m4r commented Sep 23, 2020

I like the Idea of having a mapping, to make sure we don't allow Performance Insights in an Instance that doesn't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants