Drop Store, use callback functions
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
force-pushed
the
drop-store
branch
2 times, most recently
from
94565c6
to
11c4f2a
Compare
This PR drops the Cert-D integration through Store object. I has been problematic for several small reasons: it's not possible to lookup by subkey fingerprints (the test was broken due to the primary key being `CS`). Instead of that ask the client to supply a get_certs callback function and let them plug their own lookup mechanisms (either through local storage, keyservers, or any other means). Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the Cert-D integration through
Storeobject.I has been problematic for several small reasons: it's not possible to lookup by subkey fingerprints (the test was broken due to the primary key being
CS).Instead of that ask the client to supply a
get_certscallback function and let them plug their own lookup mechanisms (either through local storage, keyservers, or any other mean).