Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing detached signatures #28

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

wiktor-k
Copy link
Owner

@wiktor-k wiktor-k commented Apr 19, 2024

Note that I have not tested reading from bytes so I'll leave that as an exercise for @ktdreyer :)

Fixes: #27

README.md Outdated Show resolved Hide resolved
Fixes: #27
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
@ktdreyer
Copy link

Thank you! That was fast.

  • from_bytes() works perfectly in my testing with some RPM files.
  • signature.issuer_fpr displays the full fingerprint string (40 hex characters, compared to PGPy's 16 characters)
  • signature.created is a datetime object with the expected time.
  • The README docs are clear.

@ktdreyer
Copy link

ktdreyer commented Apr 22, 2024

You can add "Fixes: #27" to the description of this PR to have GitHub auto-close it.

@wiktor-k wiktor-k merged commit d0e16ab into main Apr 23, 2024
15 checks passed
@wiktor-k wiktor-k deleted the add-sig-support branch April 23, 2024 06:58
@wiktor-k
Copy link
Owner Author

Okay, I've released 0.1.24 (both on PyPI and pushed a tag here). I guess that's it. Have a nice day! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: support parsing signature bytes
3 participants