Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize localization. #2263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Synchronize localization. #2263

wants to merge 1 commit into from

Conversation

winder
Copy link
Owner

@winder winder commented Jul 19, 2023

  • Push keys to POEditor
  • Download latest updates from POEditor
  • Add Serbian and zh-Hans to AvailableLanguages.java
    • Question: we have localizations for zh-CN and zh-Hans, POEditor calls them Chinese and Simplified Chinese but the Oracle International Language Environment Guide does not have zh-Hans. Can anyone recommend the correct name for these two localizations?
  • Rename mappings and resource files to match recent locale fixes.

@winder winder requested a review from breiler July 19, 2023 13:07
@breiler
Copy link
Collaborator

breiler commented Jul 19, 2023

Hi Will,

I took the liberty to register the project to Crowdin and we got a free open source license: https://translate.universalgcodesender.com/

Crowdin has a direct Github integration and creates pull requests when someone edits translations. It also has other nice features such as support for uploading screenshots to add context for a translation string. Overall I felt that Crowdin has more features that simplifies the translation.

I looked through the translations for zh-CN and zh-Hans and the translations looked very similar on many places. And according to the Java documentation and Crowdin the zh-CN is Chinese simplified. It is possible that I've messed this up, so if someone has more insights I'd be happy to correct!

If you rather use POEditor I can revert my changes. But the way it needs to be renewed I felt that I would like to move on. =)

@winder
Copy link
Owner Author

winder commented Jul 19, 2023

Neat! The screenshot feature sounds really useful and proper GitHub integration would be great. We also have an open source license for POEditor. When I was evaluating the tools originally the GH integrations were all pretty bad, POEditor edged out the rest with a decent API.

I don't have a strong opinion about switching to another service, but I'll offer some things to consider:

  • POEditor has 151 contributors.
  • The docs are setup to send people to POEditor.
  • The POEditor project was marked "archived" because I hadn't logged into it for so long, I re-enabled it last week.
  • The POEditor terms are always out of date because I manually run the update_languages.py script.
  • It looks like POEditor has improved the GH integration. It still looks pretty basic, I can't vouch for it.

I just added you as an admin to POEditor if you want to click around the site

@winder
Copy link
Owner Author

winder commented Jul 19, 2023

Looks like only 6 languages / 8 contributors have used POEditor in the last year. So the 151 contributor number is very inflated.

@breiler
Copy link
Collaborator

breiler commented Jul 22, 2023

I was not allowed to see or change the Github integration settings. We can keep the poeditor as it has a bit cleaner and more user friendly interface. I'll revert my changes for crowdin once this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants