Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker build on comment #4567

Merged
merged 8 commits into from
Oct 22, 2024
Merged

update docker build on comment #4567

merged 8 commits into from
Oct 22, 2024

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Oct 22, 2024

Important

Update Docker build job triggers in docker-image.yml to respond to specific issue comments.

  • Workflow Changes:
    • In .github/workflows/docker-image.yml, updated the condition for the build job to trigger on /buildimage_base instead of /buildimage.
    • Updated the condition for the build_ee job to include /buildimage_nsjail in addition to /buildimage_ee and /buildimage_all.

This description was created by Ellipsis for caf2b35. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to caf2b35 in 16 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/docker-image.yml:31
  • Draft comment:
    The condition now checks for '/buildimage_base' instead of '/buildimage'. Ensure this change is intentional and update documentation or comments if necessary.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. .github/workflows/docker-image.yml:93
  • Draft comment:
    The condition now includes '/buildimage_nsjail'. Ensure this change is intentional and update documentation or comments if necessary.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_2wWCpeiBYQ1dq0Lg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit c8a2f8f into main Oct 22, 2024
1 of 2 checks passed
@rubenfiszel rubenfiszel deleted the alp/buildoncomment branch October 22, 2024 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants