adding oauth.login_failure to openapi spec #4570
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to bcaf3aa in 14 seconds
More details
- Looked at
25lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/auditLogs/AuditLogsFilters.svelte:255
- Draft comment:
Ensure that the addition of 'oauth.login_failure' is consistent across the codebase. Verify that any related logic or handling for this operation is correctly implemented. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds a new operation 'oauth.login_failure' to the OpenAPI spec and the Svelte component. I need to ensure that this addition is consistent across the codebase.
Workflow ID: wflow_vV6kNr85bb5r3u7c
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Deploying windmill with
|
| Latest commit: |
bcaf3aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a2e201d.windmill.pages.dev |
| Branch Preview URL: | https://alp-oauth-login-failure.windmill.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
oauth.login_failureto OpenAPI spec and frontend audit log filters.oauth.login_failuretoopenapi.yamlundercomponents.OAUTH_LOGIN_FAILURE: 'oauth.login_failure'toAuditLogsFilters.sveltefor filtering audit logs.This description was created by
for bcaf3aa. It will automatically update as commits are pushed.