-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add full-text search on windmill service logs #4576
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to e7d9aee in 40 seconds
More details
- Looked at
1458
lines of code in21
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. backend/src/main.rs:488
- Draft comment:
Ensure that theindex_writer
is used consistently across feature flags. Currently,index_writer
is cloned and used inindexer_f
but not inlog_indexer_f
. This could lead to inconsistencies if feature flags are not set correctly. - Reason this comment was not posted:
Confidence changes required:50%
Theindex_writer
is being cloned and used in theindexer_f
async block, but it is not being used in thelog_indexer_f
async block. This could lead to confusion or errors if the feature flags are not set correctly.
2. backend/src/main.rs:814
- Draft comment:
Ensure that theindex_writer
is used consistently across feature flags. Currently,index_writer
is cloned and used inindexer_f
but not inlog_indexer_f
. This could lead to inconsistencies if feature flags are not set correctly. - Reason this comment was not posted:
Confidence changes required:50%
Theindex_writer
is being cloned and used in theindexer_f
async block, but it is not being used in thelog_indexer_f
async block. This could lead to confusion or errors if the feature flags are not set correctly.
Workflow ID: wflow_9fGfcewmwyp9eG5K
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Deploying windmill with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on dae3756 in 21 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/lib/components/search/GlobalSearchModal.svelte:39
- Draft comment:
The import forServiceLogsInner
was removed, but the component is still referenced in the description. Ensure this is intentional and that the component is not used elsewhere. - Reason this comment was not posted:
Confidence changes required:50%
The import statement for ServiceLogsInner was removed, but the component is still referenced in the description. This might be an oversight.
Workflow ID: wflow_XRxTqNTaLez2TbaY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on b152db1 in 33 seconds
More details
- Looked at
97
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. frontend/src/routes/(root)/(logged)/service_logs/+page.svelte:42
- Draft comment:
Good use ofPopover
to display parse errors for invalid search terms. - Reason this comment was not posted:
Confidence changes required:0%
ThePopover
component is used to display parse errors when the search term is invalid. Theslot="text"
is correctly used to provide the content for the popover. This is a good implementation for user feedback.
2. frontend/src/routes/(root)/(logged)/service_logs/+page.svelte:57
- Draft comment:
Usingbind:queryParseErrors
ensures that parse errors are reactive and managed properly between components. - Reason this comment was not posted:
Confidence changes required:0%
TheServiceLogsInner
component is used withbind:queryParseErrors
to handle parse errors. This ensures that any changes in the parse errors are reflected in the parent component, which is a good practice for managing state.
3. frontend/src/lib/components/ServiceLogsInner.svelte:400
- Draft comment:
UsingSplitPanesWrapper
for responsive layout is a good practice for UI adaptability. - Reason this comment was not posted:
Confidence changes required:0%
TheSplitPanesWrapper
component is used to create a responsive layout for the service logs. This is a good approach to ensure that the UI adapts to different screen sizes.
Workflow ID: wflow_P7qJIoUeohXMtpeM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 45f5bbd in 39 seconds
More details
- Looked at
208
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/lib/components/ServiceLogsInner.svelte:537
- Draft comment:
Consider optimizing thefilter
function to reduce the number of iterations overObject.entries(o2)
. This pattern is repeated in multiple places. - Reason this comment was not posted:
Confidence changes required:50%
InServiceLogsInner.svelte
, thefilter
function is used multiple times to filter logs based on conditions. This could be optimized by combining conditions or reducing the number of iterations.
2. frontend/src/lib/components/ServiceLogsInner.svelte:429
- Draft comment:
Ensure thatgetAllLogs
is called with valid date strings to avoid unexpected behavior if the API expects them. - Reason this comment was not posted:
Confidence changes required:50%
InServiceLogsInner.svelte
, thegetAllLogs
function is called withundefined
values forqueryMinTs
andqueryMaxTs
initially, which might lead to unexpected behavior if the API expects valid date strings.
Workflow ID: wflow_0IUzaPT57uoskqRr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
https://github.com/windmill-labs/windmill-ee-private/pull/79
Important
Add full-text search functionality for service logs, including backend indexing and frontend UI components.
main.rs
usingtantivy
andparquet
features.service_logs_ee.rs
for indexing service logs.openapi.yaml
with new endpoints/srch/index/search/service_logs
and/srch/index/search/count_service_logs
.lib.rs
to includeServiceLogIndexReader
and updaterun_server()
to handle log index readers.ServiceLogsInner.svelte
andLogSnippetViewer.svelte
for displaying and interacting with log search results.GlobalSearchModal.svelte
to support log search with!
prefix.SidebarContent.svelte
to include a link to service logs for superadmins.package.json
to bumplucide-svelte
version.indexer_ee.rs
tocompleted_runs_ee.rs
and createservice_logs_ee.rs
for service log indexing.This description was created by for 45f5bbd. It will automatically update as commits are pushed.