Skip to content

Commit

Permalink
fix: tsconfig options in framework are slow (#5695)
Browse files Browse the repository at this point in the history
Noticed that ts compilation tests were still timing out, wanted to partially address them.

Used https://www.totaltypescript.com/tsconfig-cheat-sheet as a good guide to build some out.
I suspect skipLibCheck will help a lot, and honestly it's probably a good thing to avoid the unnecessary .d.ts checks.

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
  • Loading branch information
MarkMcCulloh authored Feb 14, 2024
1 parent fea3d0a commit 6393069
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions libs/@wingcloud/framework/src/internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export async function compile(options: CompileOptions) {
declaration: false,
noEmitOnError: true,
listEmittedFiles: true,
allowJs: true,
skipLibCheck: true,
resolveJsonModule: true,
isolatedModules: true,
baseUrl: dirname(options.entrypoint),
paths: {
"@winglang/sdk/*": [dirname(require.resolve("@winglang/sdk")) + "/*"],
Expand Down

0 comments on commit 6393069

Please sign in to comment.