fix(compiler): unused global lifts cause sim to fail (#5720)

See #5719
We now add **all** lifts to a class's `$inflight_init`'s bindings. This makes sure the simulator sets up those objects so it can create clients for them.

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

examples/tests/valid/unused_lift.test.w

@@ -0,0 +1,31 @@
+bring cloud;
+
+let b = new cloud.Bucket();
+
+class Foo {
+  inflight access_b() {
+    b.list();
+  }
+
+  pub inflight m() {}
+}
+
+let f = new Foo();
+
+test "Use class but not method that access lifted object" {
+  f.m();
+}
+
+class Bar {
+  static inflight access_b() {
+    b.list();
+  }
+
+  pub inflight m() {}
+}
+
+let bar = new Bar();
+
+test "Use class but not static method that access lifted object" {
+  bar.m();
+}

libs/wingc/src/jsify/snapshots/access_methods_and_properties_on_collections.snap

@@ -82,6 +82,8 @@ class $Root extends $stdlib.std.Resource {
             [x.length, []],
           ],
           "$inflight_init": [
+            [((arr, index) => { if (index < 0 || index >= arr.length) throw new Error("Index out of bounds"); return arr[index]; })(y, 0), []],
+            [x.length, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/access_property_on_primitive.snap

@@ -77,6 +77,7 @@ class $Root extends $stdlib.std.Resource {
             [s.length, []],
           ],
           "$inflight_init": [
+            [s.length, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/access_property_on_value_returned_from_collection.snap

@@ -77,6 +77,7 @@ class $Root extends $stdlib.std.Resource {
             [((obj, key) => { if (!(key in obj)) throw new Error(`Map does not contain key: "${key}"`); return obj[key]; })(s, "hello").length, []],
           ],
           "$inflight_init": [
+            [((obj, key) => { if (!(key in obj)) throw new Error(`Map does not contain key: "${key}"`); return obj[key]; })(s, "hello").length, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/base_class_captures_inflight.snap

@@ -99,6 +99,7 @@ class $Root extends $stdlib.std.Resource {
             [x, []],
           ],
           "$inflight_init": [
+            [x, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/call_static_inflight_from_static_inflight.snap

@@ -123,6 +123,7 @@ class $Root extends $stdlib.std.Resource {
       get _liftMap() {
         return ({
           "$inflight_init": [
+            [A, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/calls_methods_on_preflight_object.snap

@@ -81,6 +81,7 @@ class $Root extends $stdlib.std.Resource {
             [b, ["list", "put"]],
           ],
           "$inflight_init": [
+            [b, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_from_inside_an_inflight_closure.snap

@@ -81,6 +81,7 @@ class $Root extends $stdlib.std.Resource {
             [foo, []],
           ],
           "$inflight_init": [
+            [foo, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_identifier_closure_from_preflight_scope.snap

@@ -128,6 +128,7 @@ class $Root extends $stdlib.std.Resource {
             [foo, ["handle"]],
           ],
           "$inflight_init": [
+            [foo, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_identifier_from_preflight_scope.snap

@@ -76,6 +76,7 @@ class $Root extends $stdlib.std.Resource {
             [x, []],
           ],
           "$inflight_init": [
+            [x, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_identifier_from_preflight_scope_with_method_call.snap

@@ -127,6 +127,7 @@ class $Root extends $stdlib.std.Resource {
             [f, ["bar"]],
           ],
           "$inflight_init": [
+            [f, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_identifier_from_preflight_scope_with_nested_object.snap

@@ -130,6 +130,7 @@ class $Root extends $stdlib.std.Resource {
             [f.b, ["put"]],
           ],
           "$inflight_init": [
+            [f.b, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_identifier_from_preflight_scope_with_property.snap

@@ -76,6 +76,7 @@ class $Root extends $stdlib.std.Resource {
             [x.length, []],
           ],
           "$inflight_init": [
+            [x.length, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_in_keyword_args.snap

@@ -83,6 +83,7 @@ class $Root extends $stdlib.std.Resource {
             [x, []],
           ],
           "$inflight_init": [
+            [x, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_object_with_this_in_name.snap

@@ -78,6 +78,7 @@ class $Root extends $stdlib.std.Resource {
             [bucket_this, ["put"]],
           ],
           "$inflight_init": [
+            [bucket_this, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_token.snap

@@ -77,6 +77,7 @@ class $Root extends $stdlib.std.Resource {
             [api.url, []],
           ],
           "$inflight_init": [
+            [api.url, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/capture_type_static_method.snap

@@ -131,6 +131,7 @@ class $Root extends $stdlib.std.Resource {
             [Foo, ["bars"]],
           ],
           "$inflight_init": [
+            [Foo, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/closure_field.snap

@@ -143,6 +143,7 @@ class $Root extends $stdlib.std.Resource {
                 [globalBucket, ["list"]],
               ],
               "$inflight_init": [
+                [globalBucket, []],
               ],
             });
           }
@@ -208,6 +209,7 @@ class $Root extends $stdlib.std.Resource {
             [x, ["foo"]],
           ],
           "$inflight_init": [
+            [x, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/enum_value.snap

@@ -88,6 +88,7 @@ class $Root extends $stdlib.std.Resource {
             [x, []],
           ],
           "$inflight_init": [
+            [x, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/indirect_capture.snap

@@ -116,6 +116,7 @@ class $Root extends $stdlib.std.Resource {
             [this, ["foo"]],
           ],
           "$inflight_init": [
+            [b, []],
           ],
         });
       }
@@ -150,6 +151,7 @@ class $Root extends $stdlib.std.Resource {
             [f, ["goo"]],
           ],
           "$inflight_init": [
+            [f, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/inline_inflight_class.snap

@@ -108,6 +108,7 @@ class $Root extends $stdlib.std.Resource {
                 [__parent_this_1.b, ["put"]],
               ],
               "$inflight_init": [
+                [__parent_this_1.b, []],
               ],
             });
           }

libs/wingc/src/jsify/snapshots/json_object.snap

@@ -78,6 +78,7 @@ class $Root extends $stdlib.std.Resource {
             [jsonObj1, []],
           ],
           "$inflight_init": [
+            [jsonObj1, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_binary_preflight_and_inflight_expression.snap

@@ -78,6 +78,7 @@ class $Root extends $stdlib.std.Resource {
             [x, []],
           ],
           "$inflight_init": [
+            [x, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_binary_preflight_expression.snap

@@ -79,6 +79,8 @@ class $Root extends $stdlib.std.Resource {
             [y, []],
           ],
           "$inflight_init": [
+            [x, []],
+            [y, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_element_from_collection_of_objects.snap

@@ -79,6 +79,7 @@ class $Root extends $stdlib.std.Resource {
             [((arr, index) => { if (index < 0 || index >= arr.length) throw new Error("Index out of bounds"); return arr[index]; })(a, 0), ["put"]],
           ],
           "$inflight_init": [
+            [((arr, index) => { if (index < 0 || index >= arr.length) throw new Error("Index out of bounds"); return arr[index]; })(a, 0), []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_inflight_closure.snap

@@ -129,6 +129,7 @@ class $Root extends $stdlib.std.Resource {
             [f, ["handle"]],
           ],
           "$inflight_init": [
+            [f, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_inside_preflight_method.snap

@@ -112,6 +112,7 @@ class $Root extends $stdlib.std.Resource {
                 [b, ["put"]],
               ],
               "$inflight_init": [
+                [b, []],
               ],
             });
           }

libs/wingc/src/jsify/snapshots/lift_self_reference.snap

@@ -75,6 +75,7 @@ class $Root extends $stdlib.std.Resource {
             [Foo, ["static_method"]],
           ],
           "$inflight_init": [
+            [Foo, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_string.snap

@@ -76,6 +76,7 @@ class $Root extends $stdlib.std.Resource {
             [b, []],
           ],
           "$inflight_init": [
+            [b, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_this.snap

@@ -149,6 +149,7 @@ class $Root extends $stdlib.std.Resource {
             [f, ["foo"]],
           ],
           "$inflight_init": [
+            [f, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_via_closure.snap

@@ -105,6 +105,7 @@ class $Root extends $stdlib.std.Resource {
             [bucket, ["put"]],
           ],
           "$inflight_init": [
+            [bucket, []],
           ],
         });
       }
@@ -139,6 +140,7 @@ class $Root extends $stdlib.std.Resource {
             [fn, ["handle"]],
           ],
           "$inflight_init": [
+            [fn, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/lift_via_closure_class_explicit.snap

@@ -158,6 +158,7 @@ class $Root extends $stdlib.std.Resource {
             [fn, ["handle"]],
           ],
           "$inflight_init": [
+            [fn, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/nested_inflight_after_preflight_operation.snap

@@ -134,6 +134,7 @@ class $Root extends $stdlib.std.Resource {
             [y, ["b"]],
           ],
           "$inflight_init": [
+            [y, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/nested_preflight_operation.snap

@@ -180,6 +180,7 @@ class $Root extends $stdlib.std.Resource {
             [t.y.b, ["put"]],
           ],
           "$inflight_init": [
+            [t.y.b, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/no_lift_shadow_inside_inner_scopes.snap

@@ -87,6 +87,7 @@ class $Root extends $stdlib.std.Resource {
             [i, []],
           ],
           "$inflight_init": [
+            [i, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_collection.snap

@@ -80,6 +80,8 @@ class $Root extends $stdlib.std.Resource {
             [a.length, []],
           ],
           "$inflight_init": [
+            [((arr, index) => { if (index < 0 || index >= arr.length) throw new Error("Index out of bounds"); return arr[index]; })(a, 0), []],
+            [a.length, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_collection_of_preflight_objects.snap

@@ -85,6 +85,8 @@ class $Root extends $stdlib.std.Resource {
             [arr.length, []],
           ],
           "$inflight_init": [
+            [((arr, index) => { if (index < 0 || index >= arr.length) throw new Error("Index out of bounds"); return arr[index]; })(arr, 0), []],
+            [arr.length, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_nested_object_with_operations.snap

@@ -130,6 +130,7 @@ class $Root extends $stdlib.std.Resource {
             [a.bucky, ["list"]],
           ],
           "$inflight_init": [
+            [a.bucky, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_object.snap

@@ -133,6 +133,7 @@ class $Root extends $stdlib.std.Resource {
             [pf_obj, ["goodbye", "hello"]],
           ],
           "$inflight_init": [
+            [pf_obj, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_object_through_property.snap

@@ -131,6 +131,7 @@ class $Root extends $stdlib.std.Resource {
             [t.b, ["put"]],
           ],
           "$inflight_init": [
+            [t.b, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_object_with_operations.snap

@@ -80,6 +80,7 @@ class $Root extends $stdlib.std.Resource {
             [b, ["list", "put"]],
           ],
           "$inflight_init": [
+            [b, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_object_with_operations_multiple_methods.snap

@@ -86,6 +86,7 @@ class $Root extends $stdlib.std.Resource {
             [b, ["list"]],
           ],
           "$inflight_init": [
+            [b, []],
           ],
         });
       }

libs/wingc/src/jsify/snapshots/preflight_value_field.snap

@@ -140,6 +140,9 @@ class $Root extends $stdlib.std.Resource {
             [t.name.length, []],
           ],
           "$inflight_init": [
+            [t.last, []],
+            [t.name, []],
+            [t.name.length, []],
           ],
         });
       }