Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(sdk): making cron schedule more cloud agnostic #5953

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

hasanaburayyan
Copy link
Contributor

This reverts commit 81fbfb5.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@hasanaburayyan hasanaburayyan requested a review from a team as a code owner March 16, 2024 01:58
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-5953.fly.dev 🚀

Last Updated (UTC) 2024-03-16 02:02

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 59ms±0.52 60ms±0.93 +1ms (+1.47%)⬜
empty.test.w -t sim 534ms±51.09 486ms±5.91 -48ms (-8.92%)⬜
empty.test.w -t tf-aws 705ms±5.79 711ms±6.4 +6ms (+0.84%)⬜
hello_world.test.w -t sim 516ms±3.11 521ms±9.17 +6ms (+1.09%)⬜
hello_world.test.w -t tf-aws 1641ms±10.06 1649ms±6.52 +8ms (+0.51%)⬜
functions_10.test.w -t sim 590ms±10.02 603ms±14.76 +14ms (+2.37%)⬜
functions_10.test.w -t tf-aws 2221ms±12.33 2233ms±6.55 +12ms (+0.54%)⬜
jsii_small.test.w -t sim 491ms±3.03 495ms±3.06 +4ms (+0.72%)⬜
jsii_small.test.w -t tf-aws 708ms±4.17 712ms±5.34 +3ms (+0.49%)⬜
jsii_big.test.w -t sim 2889ms±9.49 2908ms±13.29 +19ms (+0.65%)⬜
jsii_big.test.w -t tf-aws 3105ms±7.17 3121ms±9.67 +16ms (+0.52%)⬜
functions_1.test.w -t sim 522ms±5.05 518ms±5.16 -4ms (-0.79%)⬜
functions_1.test.w -t tf-aws 943ms±7.74 942ms±4.8 -1ms (-0.09%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 59ms 63ms 1ms 1ms
empty.test.w -t sim 486ms 475ms 505ms 6ms 8ms
empty.test.w -t tf-aws 711ms 690ms 720ms 6ms 9ms
hello_world.test.w -t sim 521ms 507ms 554ms 9ms 13ms
hello_world.test.w -t tf-aws 1649ms 1630ms 1663ms 7ms 9ms
functions_10.test.w -t sim 603ms 573ms 645ms 15ms 21ms
functions_10.test.w -t tf-aws 2233ms 2215ms 2252ms 7ms 9ms
jsii_small.test.w -t sim 495ms 485ms 499ms 3ms 4ms
jsii_small.test.w -t tf-aws 712ms 702ms 722ms 5ms 7ms
jsii_big.test.w -t sim 2908ms 2884ms 2939ms 13ms 19ms
jsii_big.test.w -t tf-aws 3121ms 3100ms 3140ms 10ms 14ms
functions_1.test.w -t sim 518ms 509ms 528ms 5ms 7ms
functions_1.test.w -t tf-aws 942ms 932ms 951ms 5ms 7ms
Last Updated (UTC) 2024-03-16 02:07

Copy link
Contributor

mergify bot commented Mar 16, 2024

Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if revert-5870-removing-question-mark-schedule is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit d9beaf1 into main Mar 16, 2024
16 checks passed
@mergify mergify bot deleted the revert-5870-removing-question-mark-schedule branch March 16, 2024 02:08
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.8.

@staycoolcall911
Copy link
Contributor

This PR reverted #5870 due to a failing sdk spec test: https://github.com/winglang/wing/actions/runs/8304298940/job/22729804328#step:12:1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants