feat(sdk): dead letter queue support for queues #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉
|
eladb
changed the title
eladb
previously requested changes
Mar 25, 2024
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
Co-authored-by: Elad Ben-Israel <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Co-authored-by: Elad Ben-Israel <[email protected]>
Co-authored-by: Elad Ben-Israel <[email protected]>
Co-authored-by: Elad Ben-Israel <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Chriscbr
reviewed
Apr 1, 2024
Chriscbr
reviewed
Apr 17, 2024
There was a problem hiding this comment.
PR is looking good @marciocadev - just a few comments left and it should be good to go 🙂
examples/tests/sdk_tests/website/react-website/build/public/index.html
Outdated
Show resolved
Hide resolved
Signed-off-by: monada-bot[bot] <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
Co-authored-by: Chris Rybicki <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
Chriscbr
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Awesome work @marciocadev (adding support for three targets! 🤯)
Chriscbr
removed
the
⚠️ pr/review-mutation
monadabot
added
the
⚠️ pr/review-mutation
marciocadev
removed
the
⚠️ pr/review-mutation
|
Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if |
|
Congrats! 🚀 This was released in Wing 0.71.2. |
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
Fixes a regression from #6060 that prevented messages from being processed in parallel (we noticed this bug when it caused test failures in one of our winglibs: https://github.com/winglang/winglibs/actions/runs/8767429765/job/24060674878). I confirmed the updated test (set_consumer.test.w) passes when ran on my AWS account using the `tf-aws` target. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔ As the dead-letter queue linked to the function is a specific case of AWS, I will remove it from the scope of this PR.
dlq for function (tf-aws / awscdk)dlq for function (sim)Closes #6033
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.