Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflicting SIGINT handlers #6275

Closed
wants to merge 2 commits into from
Closed

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Apr 19, 2024

There were two competing SIGINT handlers and the result was unreleased Console resources. This PR does the following:

  • Moves the @wingconsole/server's conf dev dependency to dependencies, so we don't bundle when-exit
  • Uses the same when-exit package in winglang

By applying the listed changes above, all SIGINT handlers will be managed by when-exit, so there shouldn't be any conflict now.

Fixes #6018.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@skyrpex skyrpex marked this pull request as ready for review April 19, 2024 14:29
@skyrpex skyrpex requested review from ainvoner, polamoros, eladcon and a team as code owners April 19, 2024 14:29
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-6275.fly.dev 🚀

Last Updated (UTC) 2024-04-19 14:31

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜⬜⬜
Benchmark Before After Change
version 59ms±0.45 61ms±0.86 +2ms (+3.01%)⬜
functions_1.test.w -t sim 408ms±25.14 405ms±7.61 -3ms (-0.82%)⬜
functions_1.test.w -t tf-aws 819ms±9.03 821ms±7.23 +1ms (+0.15%)⬜
jsii_big.test.w -t sim 2793ms±15.1 2796ms±16.78 +3ms (+0.1%)⬜
jsii_big.test.w -t tf-aws 3005ms±14.83 3004ms±9.29 -1ms (-0.03%)⬜
functions_10.test.w -t sim 489ms±5.93 483ms±10.86 -6ms (-1.19%)⬜
functions_10.test.w -t tf-aws 2009ms±9.78 2030ms±17.57 +20ms (+1.01%)⬜
jsii_small.test.w -t sim 365ms±4.4 369ms±3.34 +4ms (+1.03%)⬜
jsii_small.test.w -t tf-aws 597ms±2.99 606ms±4.03 +9ms (+1.48%)🟥
empty.test.w -t sim 364ms±6.04 368ms±3.66 +4ms (+1.23%)⬜
empty.test.w -t tf-aws 593ms±5.75 593ms±4.6 +0ms (+0.03%)⬜
hello_world.test.w -t sim 393ms±3.86 400ms±3.93 +7ms (+1.67%)⬜
hello_world.test.w -t tf-aws 1512ms±6.18 1514ms±7.44 +1ms (+0.09%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 61ms 59ms 63ms 1ms 1ms
functions_1.test.w -t sim 405ms 389ms 424ms 8ms 11ms
functions_1.test.w -t tf-aws 821ms 802ms 836ms 7ms 10ms
jsii_big.test.w -t sim 2796ms 2761ms 2844ms 17ms 23ms
jsii_big.test.w -t tf-aws 3004ms 2991ms 3032ms 9ms 13ms
functions_10.test.w -t sim 483ms 464ms 503ms 11ms 15ms
functions_10.test.w -t tf-aws 2030ms 1994ms 2062ms 18ms 25ms
jsii_small.test.w -t sim 369ms 364ms 379ms 3ms 5ms
jsii_small.test.w -t tf-aws 606ms 602ms 617ms 4ms 6ms
empty.test.w -t sim 368ms 358ms 375ms 4ms 5ms
empty.test.w -t tf-aws 593ms 586ms 607ms 5ms 6ms
hello_world.test.w -t sim 400ms 392ms 408ms 4ms 5ms
hello_world.test.w -t tf-aws 1514ms 1493ms 1530ms 7ms 10ms
Last Updated (UTC) 2024-04-19 14:36

@skyrpex skyrpex closed this Apr 22, 2024
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
There were two competing `SIGINT` handlers and the result was unreleased Console resources.

This PR removes the `conf` package (which was registering a `SIGINT` handler) in favor of simple read and write methods for the config file.

Fixes #6018. Supersedes #6275.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dangling" resources
5 participants