-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: conflicting SIGINT
handlers
#6275
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-6275.fly.dev 🚀 Last Updated (UTC) 2024-04-19 14:31 |
BenchmarksComparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-04-19 14:36 |
There were two competing
SIGINT
handlers and the result was unreleased Console resources. This PR does the following:@wingconsole/server
'sconf
dev dependency to dependencies, so we don't bundlewhen-exit
when-exit
package inwinglang
By applying the listed changes above, all
SIGINT
handlers will be managed bywhen-exit
, so there shouldn't be any conflict now.Fixes #6018.