Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): cloud.Topic publish() support variadic parameter #6281

Merged
merged 14 commits into from
Apr 30, 2024

Conversation

marciocadev
Copy link
Collaborator

Now we can send multiple messages at once to a topic.

Closes #6072

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@marciocadev marciocadev requested a review from a team as a code owner April 21, 2024 02:35
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 21, 2024
Copy link
Contributor

@tsuf239 tsuf239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 21, 2024
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 22, 2024
Copy link
Contributor

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Apr 23, 2024

refresh

✅ Pull request refreshed

@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 23, 2024
@tsuf239
Copy link
Contributor

tsuf239 commented Apr 30, 2024

waiting for tests to pass here: https://github.com/winglang/wing/actions/runs/8891622816/job/24413961814

Copy link
Contributor

mergify bot commented Apr 30, 2024

Thanks for contributing, @marciocadev! This PR will now be added to the merge queue, or immediately merged if topic-variadic is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Apr 30, 2024
@mergify mergify bot merged commit 8329f47 into winglang:main Apr 30, 2024
13 checks passed
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.73.12.

@marciocadev marciocadev deleted the topic-variadic branch June 2, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud.Topic publish() support variadic parameter
5 participants