Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge queue: embarking main (87c2713) and #6289 together #6292

Closed
wants to merge 2 commits into from
Closed

merge queue: embarking main (87c2713) and #6289 together #6292

wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2024 •
edited
Loading

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (87c2713) and #6289 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #6289.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue default for merge:

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 6289
...

skyrpex and others added 2 commits April 22, 2024 11:24
@skyrpex
fix: conflicting SIGINT handlers
f1043e3 
There were two competing `SIGINT` handlers and the result was unreleased Console resources.

This PR removes the `conf` package (which was registering a `SIGINT` handler) in favor of simple read and write methods for the config file.

Fixes #6018.
@mergify
Merge of #6289
5cc5698
@mergify mergify bot closed this Apr 22, 2024
@mergify mergify bot deleted the mergify/merge-queue/4348b50f0c branch April 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skyrpex