Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add support for the forceDestroy property on the bucket #7213

Merged
merged 8 commits into from
Nov 1, 2024

Conversation

ShaiBer
Copy link
Contributor

@ShaiBer ShaiBer commented Oct 31, 2024

The forceDestroy property allows to delete a bucket that contains objects

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@ShaiBer ShaiBer requested a review from a team as a code owner October 31, 2024 18:00
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

@monadabot
Copy link
Contributor

monadabot commented Oct 31, 2024

Console preview environment is available at https://wing-console-pr-7213.fly.dev 🚀

Last Updated (UTC) 2024-10-31 21:39

@ShaiBer ShaiBer requested a review from eladb October 31, 2024 19:17
@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜🟥🟥🟥⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 57ms±0.77 56ms±0.72 -1ms (-1.85%)⬜
jsii_small.test.w -t sim 381ms±3.96 391ms±13.43 +10ms (+2.65%)⬜
jsii_small.test.w -t tf-aws 612ms±4.99 643ms±96.13 +31ms (+5.09%)🟥
functions_10.test.w -t sim 515ms±22.29 542ms±96.7 +27ms (+5.28%)🟥
functions_10.test.w -t tf-aws 2201ms±23.16 2285ms±243.77 +85ms (+3.84%)🟥
jsii_big.test.w -t sim 2978ms±11.04 2937ms±18.6 -41ms (-1.38%)⬜
jsii_big.test.w -t tf-aws 3159ms±21.35 3131ms±12.71 -28ms (-0.9%)⬜
functions_1.test.w -t sim 414ms±7.85 399ms±6.34 -15ms (-3.54%)⬜
functions_1.test.w -t tf-aws 849ms±9.19 833ms±4.34 -16ms (-1.89%)⬜
hello_world.test.w -t sim 412ms±4.62 408ms±4.09 -3ms (-0.79%)⬜
hello_world.test.w -t tf-aws 1498ms±5.96 1488ms±5.96 -10ms (-0.67%)⬜
empty.test.w -t sim 380ms±3.28 372ms±5.95 -8ms (-2.16%)⬜
empty.test.w -t tf-aws 600ms±3.22 594ms±5.4 -6ms (-0.95%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 56ms 55ms 58ms 1ms 1ms
jsii_small.test.w -t sim 391ms 377ms 436ms 13ms 19ms
jsii_small.test.w -t tf-aws 643ms 591ms 1025ms 96ms 134ms
functions_10.test.w -t sim 542ms 476ms 925ms 97ms 135ms
functions_10.test.w -t tf-aws 2285ms 2150ms 3251ms 244ms 341ms
jsii_big.test.w -t sim 2937ms 2901ms 2994ms 19ms 26ms
jsii_big.test.w -t tf-aws 3131ms 3112ms 3159ms 13ms 18ms
functions_1.test.w -t sim 399ms 388ms 419ms 6ms 9ms
functions_1.test.w -t tf-aws 833ms 823ms 844ms 4ms 6ms
hello_world.test.w -t sim 408ms 400ms 417ms 4ms 6ms
hello_world.test.w -t tf-aws 1488ms 1471ms 1498ms 6ms 8ms
empty.test.w -t sim 372ms 360ms 386ms 6ms 8ms
empty.test.w -t tf-aws 594ms 580ms 601ms 5ms 8ms
Last Updated (UTC) 2024-10-31 19:22

Signed-off-by: monada-bot[bot] <[email protected]>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 31, 2024
@ShaiBer ShaiBer merged commit ee1ab4b into main Nov 1, 2024
13 checks passed
@ShaiBer ShaiBer deleted the add-forcedestroy-to-bucket branch November 1, 2024 08:28
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants