-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements #383
Minor improvements #383
Conversation
This reverts commit c03835c.
@winstxnhdw here |
Color players
I don’t think we need to render bounds for logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just added complexity that I really don’t care enough to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it just allows to see enemies in-game, i dont get it why you would need to write it only on the logs?
and is the same command, just it will allow you to spawn and possess a enemy immediately somewhat like Control Company does.
if you want to simplify it, go ahead!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what YOU wanted to add and you’ve now selfishly pushed this code onto me to maintain. Do you not see how wrong is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what YOU wanted to add and you’ve now selfishly pushed this code onto me to maintain. Do you not see how wrong is this?
That’s how I figured it, but if you want to make a better approach than this , you can remake the /spawn command! Once you finish it i can remove the modified command here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess what. Refactoring takes time and effort. I have other things I need to do as well. I can’t always fix the code you guys send me. It’s mostly not worth the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess what. Refactoring takes time and effort. I have other things I need to do as well. I can’t always fix the code you guys send me. It’s mostly not worth the time.
There’s nothing to refractor here, just moved a couple things in helper.enemies and removed the duplicated code, ill rewrite spawn once im home
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s only what you think. I want to keep as many commands stateless, but you insist on sharing the enemy dictionary. It’s not necessary. Nobody is going to use the enemies
command more than a few times or even at all. Most users know the name of the enemies, why do we have to spoonfeed unnecessarily?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s only what you think. I want to keep as many commands stateless, but you insist on sharing the enemy dictionary. It’s not necessary. Nobody is going to use the
enemies
command more than a few times or even at all. Most users know the name of the enemies, why do we have to spoonfeed unnecessarily?
Because they know only the stock ones, until that i did not know there was a second test enemy from the game, which has the name red pill, and it can be used to see which enemies the mods added as well for spawning and controlling them with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I am convinced. But since we are going to do this, we should do this for all commands. I'll think about how best to do it.
yes, is a good way because the way you do it shows them but then even if you pick em up it will stay there. |
@winstxnhdw i dont get it this time, what’s the problem? |
This is what I am going to do.
|
30c12b5
to
8de64bf
Compare
4d7200c
to
095fd33
Compare
f1bfe19
to
1411cd1
Compare
Add more colors
Make ESP give more colors for each item.
Make ESP Show Gift's contents and values
Make ESP Show Story Logs renderers better and hide when grabbed or not visibile any more.
Move Enemy List in Helper and filter as well which we use both in spawn and enemies command
Make Spawn allow for spawn and possess if spawned under Phantom