-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use external camera #419
Open
xAstroBoy
wants to merge
234
commits into
winstxnhdw:main
Choose a base branch
from
xAstroBoy:New-Camera
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
use external camera #419
Changes from 5 commits
Commits
Show all changes
234 commits
Select commit
Hold shift + click to select a range
a1861e7
use external camera
xAstroBoy 458a952
Remove stuff
xAstroBoy 1514ccc
Merge branch 'main' into New-Camera
xAstroBoy 17be599
style: format scripts
github-actions[bot] 954733d
Update LcHaxCamera.cs
xAstroBoy 4ac4d9c
Update lc-hax/Scripts/Helpers/Players.cs
xAstroBoy 8c6421e
Remove pepega moment
xAstroBoy 60dab09
style: format scripts
github-actions[bot] 319a5ba
Update LcHaxCamera.cs
xAstroBoy 774a57a
style: format scripts
github-actions[bot] 65ae816
Discard changes to lc-hax/Scripts/Modules/Possession/Controllers/Brac…
xAstroBoy 3547b79
Merge branch 'main' into New-Camera
winstxnhdw dffa8e3
Update LcHaxCamera.cs
xAstroBoy 68ac2d4
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 9380d0d
Update LcHaxCamera.cs
xAstroBoy 7fa117c
Update LcHaxCamera.cs
xAstroBoy e9fc937
Update LcHaxCamera.cs
xAstroBoy df7bcba
Fixes
xAstroBoy 2a3101f
style: format scripts
github-actions[bot] 454adb4
Fix jester not killing & bugfixes
xAstroBoy d2566ff
style: format scripts
github-actions[bot] e1b2689
Update JesterEnemyController.cs
xAstroBoy 54fa508
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy e539a31
style: format scripts
github-actions[bot] 2d21d4a
Update MaskedController.cs
xAstroBoy a50f661
style: format scripts
github-actions[bot] 7a0314c
Update MaskedController.cs
xAstroBoy b0e046d
Minor fixes and call collision of enemies that aren't supposed to be …
xAstroBoy 5f3365a
foward collision with player to enemy collision detection.
xAstroBoy b0e7bd9
Update SandSpiderController.cs
xAstroBoy 6ea97a9
foward collision with player to enemy collision detection.
xAstroBoy 7688b39
Update PossessionMod.cs
xAstroBoy 5be2bac
Update PossessionMod.cs
xAstroBoy a5030d6
Add Kills for inside enemies if they are outside
xAstroBoy 10c543d
style: format scripts
github-actions[bot] 36c49bf
fixes
xAstroBoy 5056eb9
style: format scripts
github-actions[bot] 2593e7b
fixes
xAstroBoy 4f5a716
Update PhantomMod.cs
xAstroBoy f90fdc6
Final Fixes
xAstroBoy fd8f417
style: format scripts
github-actions[bot] f90153a
thans @D1GQ
xAstroBoy 4bc7d3b
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy cf268c4
Update HoardingBugController.cs
xAstroBoy 8d842a9
Make Lc-Hax camera a core module.
xAstroBoy c494225
style: format scripts
github-actions[bot] 3d7311d
dont spawn it , only phantom can spawn the hax camera.
xAstroBoy 93d884c
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy f65f3a9
apply @D1GQ Changes
xAstroBoy 65a14c5
Update JesterEnemyController.cs
xAstroBoy 99eb129
remove killAnimation Check.
xAstroBoy c0301a8
Fix Jester & Spider
xAstroBoy fae48cb
Fix ClientID
xAstroBoy 33ecfad
style: format scripts
github-actions[bot] e6cff54
Merge branch 'main' into New-Camera
winstxnhdw c1e31ab
Apply suggestions from code review
xAstroBoy 0b2bd7a
Update JesterEnemyController.cs
xAstroBoy 3595251
Fix Kill Animation
xAstroBoy 21ebf09
Merge branch 'main' into New-Camera
winstxnhdw 132c33b
style: format scripts
github-actions[bot] ca4a607
refactor: use actual enemy names
winstxnhdw 924c36a
Added camera offsets to all enemies
D1GQ b417761
Added old enemy rotation back for no clip.
D1GQ ea177a1
Update BaboonHawkController.cs
xAstroBoy db6718e
Update BrackenController.cs
xAstroBoy 50f0094
Merge pull request #2 from D1GQ/main
xAstroBoy 8817478
Update BaboonHawkController.cs
xAstroBoy c436282
style: format scripts
github-actions[bot] 0c92940
add treshold back
xAstroBoy 1d9dda1
Update SandSpiderController.cs
xAstroBoy 70fd167
Get rid of OnPlayerCollision, just patch PlayerTargetable
xAstroBoy e4993db
restore chqnges
xAstroBoy 149d153
restore chqnges
xAstroBoy a1fff9f
Get rid of OnPlayerCollision, just patch PlayerTargetable
xAstroBoy b5671ab
style: format scripts
github-actions[bot] 6b40084
style: format scripts
github-actions[bot] 94e7ebc
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 039ae74
Update HoardingBugController.cs
xAstroBoy 233a6b9
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 69f2fea
Merge pull request #3 from D1GQ/main
xAstroBoy f6067ff
Renaming
xAstroBoy cbb85bc
Fix Spider rotation for good
xAstroBoy 6fee407
Better approach for Cam & Position offsets
xAstroBoy e738e67
cleanup
xAstroBoy 40a54b4
style: format scripts
github-actions[bot] ae0cf5f
add X offset for camera (if needed)
xAstroBoy 4e95328
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 69ab3a4
style: format scripts
github-actions[bot] f9bfe92
Update EyelessDogController.cs
xAstroBoy b39b3f0
style: format scripts
github-actions[bot] 0e99a59
Merge branch 'main' into New-Camera
winstxnhdw 19a1624
Merge branch 'main' into New-Camera
winstxnhdw ae7a8ca
Merge branch 'main' into New-Camera
winstxnhdw 20f6256
perf(reflector): add caching capability
winstxnhdw 1a9812f
Merge branch 'main' into New-Camera
xAstroBoy afb6219
Merge branch 'main' into New-Camera
winstxnhdw e5e91a7
style: format scripts
github-actions[bot] 512b32d
Dont destroy camera anymore
xAstroBoy 95975f3
style: format scripts
github-actions[bot] 3cef6b7
Attempt to make camera exactly where player is looking at.
xAstroBoy 719426e
style: format scripts
github-actions[bot] 80dd516
Update HaxCamera.cs
xAstroBoy b7cfd37
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 0090eb6
style: format scripts
github-actions[bot] c7abbb4
Minor fixes
xAstroBoy d67f9e6
Update HaxCamera.cs
xAstroBoy 7fb3bfc
Update HaxCamera.cs
xAstroBoy b6e27c7
turn gameobject directly than component.
xAstroBoy 9140e5c
Update HaxCamera.cs
xAstroBoy 2ec1877
style: format scripts
github-actions[bot] 7b0ba13
Merge branch 'main' into New-Camera
xAstroBoy fbf9c6d
Update PhantomMod.cs
xAstroBoy 3e709bc
style: format scripts
github-actions[bot] 077794b
Update HaxCamera.cs
xAstroBoy 73c5157
style: format scripts
github-actions[bot] c6e3996
Fix camera not deactivating
xAstroBoy bea15e1
Update Camera.cs
xAstroBoy 99a8c56
style: format scripts
github-actions[bot] 6d6d8fb
Bring camera disabler again
xAstroBoy 3507722
Since we are not setting the parent, we copy the camera properties
xAstroBoy d0d8231
use ActiveCamera from now on
xAstroBoy 5e3f31b
style: format scripts
github-actions[bot] 7da9d91
Update PlayerIsTargetablePatch.cs
xAstroBoy 3f7f038
Merge pull request #4 from D1GQ/main
xAstroBoy 7b830ac
style: format scripts
github-actions[bot] b698f3a
Update PossessionPatch.cs
xAstroBoy 235fb20
style: format scripts
github-actions[bot] d9ebb82
Update PossessionPatch.cs
xAstroBoy b5029a0
style: format scripts
github-actions[bot] 2f90006
Update PossessionPatch.cs
xAstroBoy 92278ba
Fixed 9967d56c6ef19af86424e8ed04459a42df6aac24 change that broke Cent…
xAstroBoy 0d78be7
style: format scripts
github-actions[bot] e927bdc
Update PlayerIsTargetablePatch.cs
xAstroBoy 4c5a8c1
style: format scripts
github-actions[bot] 71b50f9
Update PlayerIsTargetablePatch.cs
xAstroBoy e42bab4
style: format scripts
github-actions[bot] f47199b
Update PlayerIsTargetablePatch.cs
xAstroBoy cee2348
Remove Ghost Girl WIP Controller
xAstroBoy 38cae27
Update PossessionMod.cs
xAstroBoy f7a6c88
Update PlayerIsTargetablePatch.cs
xAstroBoy b458261
Merge branch 'winstxnhdw:main' into New-Camera
xAstroBoy 085467e
use the right states
xAstroBoy 1969e2e
style: format scripts
github-actions[bot] 8142955
Fixes
xAstroBoy 75095a4
style: format scripts
github-actions[bot] bbf7282
Have a longer delay if in SENTRY mode
D1GQ 3625403
Merge pull request #5 from D1GQ/main
xAstroBoy 62543d7
Fixes
xAstroBoy 8648749
Fixes
xAstroBoy fbfdcf5
style: format scripts
github-actions[bot] e301cde
Fixed issues with spider nesting.
D1GQ 533f547
Merge branch 'main' of https://github.com/D1GQ/lc-hax-small-controlle…
D1GQ a4add73
Fixed reoccurring IsAbleToMove issues
D1GQ e8f8d21
Hoarder Bug special ability, Play chitterSFX, if Modded Yippee.
D1GQ e0eda9c
Merge pull request #6 from D1GQ/main
xAstroBoy 7c98630
Overhaul of PossessionMod
xAstroBoy 2db69ea
Overhaul of PossessionMod
xAstroBoy acd5961
style: format scripts
github-actions[bot] 611c85d
Update HoardingBugController.cs
xAstroBoy b45bb2d
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 9610d11
Update PossessionMod.cs
xAstroBoy b0654fb
style: format scripts
github-actions[bot] 2935fef
Discard changes to lc-hax/Scripts/Commands/Mod Toggles/SanityToggle.cs
xAstroBoy c1f1618
Discard changes to lc-hax/Scripts/Commands/UnlimitedJumpCommand.cs
xAstroBoy 86cee92
Discard changes to lc-hax/Scripts/Modules/SaneMod.cs
xAstroBoy a42d507
Update HoardingBugController.cs
xAstroBoy 6494b09
Disable certain keys if typing.
xAstroBoy a27616b
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 95c3873
Update PossessionPatch.cs
xAstroBoy 3c42f4a
block possession movement if typing.
xAstroBoy 5fd264c
style: format scripts
github-actions[bot] 7d4a270
Update HudPatch.cs
xAstroBoy bd2f85f
Update HudPatch.cs
xAstroBoy 5a900e7
Update HudPatch.cs
xAstroBoy 1986b27
style: format scripts
github-actions[bot] bc2b2bd
Update PossessionMod.cs
xAstroBoy cc27f5a
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy fa8fdac
Remove cooldown, use E to interact
xAstroBoy a9013b3
make instead interact than just move
xAstroBoy 37a22bd
style: format scripts
github-actions[bot] 2322737
allow enemies to open/close doors.
xAstroBoy bad384b
Merge branch 'New-Camera' of https://github.com/xAstroBoy/lc-hax into…
xAstroBoy 9459239
allow enemies to open/close doors.
xAstroBoy da39153
style: format scripts
github-actions[bot] 420f678
Merge branch 'main' into New-Camera
winstxnhdw e21d88f
Fixes and allow interaction with E on doors for enemies.
xAstroBoy 253592c
Fixes and allow interaction with E on doors for enemies.
xAstroBoy 443b5b6
style: format scripts
github-actions[bot] 7887539
Cleanup and prevent raycast if maxrange is 0
xAstroBoy 384c7b0
style: format scripts
github-actions[bot] 3c7d15a
Cleanup
xAstroBoy 0ce5e0f
style: format scripts
github-actions[bot] 40f2c00
Update MaskedController.cs
xAstroBoy 69b6a17
Merge branch 'main' into New-Camera
xAstroBoy 4d7200c
feat: introduce experimental `fall` command
winstxnhdw 5ed85de
Merge branch 'main' into New-Camera
winstxnhdw 1d2724c
Merge branch 'main' into New-Camera
xAstroBoy aba1218
Discard changes to lc-hax/Scripts/Commands/FallCommand.cs
xAstroBoy 1672df3
Merge branch 'main' into New-Camera
winstxnhdw 554d813
Merge branch 'main' into New-Camera
winstxnhdw 02318b2
refactor: remove redundant conditionals
winstxnhdw 62d10aa
Merge branch 'main' into New-Camera
winstxnhdw 8e890d7
style: fix whitespaces and indentation
winstxnhdw d85b4b2
refactor: cheat-relevant code should not be coupled with generic list…
winstxnhdw 40eca1b
refactor/perf: infinitely cleaner and some perf wins
winstxnhdw 2b0dd62
style: format scripts
github-actions[bot] 2c7809b
feat: add `space` event
winstxnhdw 756ad78
refactor: clean up baboon and bracken controllers
winstxnhdw e2ef82f
Merge branch 'main' into New-Camera
winstxnhdw 90e5057
refactor: clean up controllers
winstxnhdw 16b32a7
Merge branch 'main' into New-Camera
winstxnhdw 48602a2
style: use full name consistently
winstxnhdw c93264b
fix: properly toggle sprinting
winstxnhdw 90c60c7
feat: nobody asked for this
winstxnhdw 0bc6215
refactor: bring back possession patch
winstxnhdw c875fee
chore: revert HUDPatch
winstxnhdw 94286d6
refactor: light clean up
winstxnhdw 729dc6e
refactor: abstract long condition into method
winstxnhdw 1d93b7f
feat: allow enemies to attack outside
winstxnhdw 275daeb
style: rearrange and rename
winstxnhdw 778dc4a
Merge branch 'main' into New-Camera
winstxnhdw c5b9e83
refactor: massively cleaner HaxCamera
winstxnhdw b39c60e
refactor: certain things need not be copied
winstxnhdw 2a365f3
refactor: no longer necessary to disable kb and mouse
winstxnhdw eb7c0f4
refactor: remove unnecessary internal
winstxnhdw 75eb030
feat/docs: set all placeable objects upright
winstxnhdw cd1881a
Merge branch 'main' into New-Camera
winstxnhdw f32b719
Merge branch 'main' into New-Camera
winstxnhdw 9720f2a
Merge branch 'main' into New-Camera
winstxnhdw 6bf31e5
Merge branch 'main' into New-Camera
winstxnhdw 88768fb
Merge branch 'main' into New-Camera
winstxnhdw 70bbbd8
Merge branch 'main' into New-Camera
winstxnhdw 1bdbf05
Merge branch 'main' into New-Camera
xAstroBoy 31e830b
Merge branch 'main' into New-Camera
winstxnhdw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
using UnityEngine; | ||
using UnityEngine.Rendering.HighDefinition; | ||
|
||
#pragma warning disable CS8603 // Possible null reference return. | ||
|
||
namespace Hax; | ||
|
||
internal static partial class Helper { | ||
|
||
internal static Camera? GameCamera => | ||
Helper.LocalPlayer?.gameplayCamera is Camera { enabled: true } gameplayCamera | ||
? gameplayCamera | ||
: Helper.StartOfRound?.spectateCamera; | ||
|
||
static GameObject? CustomCameraObj = null; | ||
|
||
static Camera? CustomCamera; | ||
|
||
internal static void DestroyCustomCam() { | ||
if (CustomCameraObj != null) { | ||
Object.DestroyImmediate(CustomCameraObj); | ||
} | ||
|
||
CustomCameraObj = null; | ||
CustomCamera = null; | ||
if (!Helper.LocalPlayer.IsDead()) { | ||
if (Helper.LocalPlayer?.gameplayCamera is Camera camData) { | ||
camData.enabled = true; | ||
} | ||
} | ||
} | ||
|
||
internal static Camera GetCustomCamera() { | ||
if (Helper.LocalPlayer?.gameplayCamera is not Camera camData) return null; | ||
if (CustomCamera is not null) return CustomCamera; | ||
CustomCameraObj ??= new GameObject("lc-hax Camera"); | ||
|
||
Camera? newCam = CustomCameraObj.AddComponent<Camera>(); | ||
if (newCam is null) return null; | ||
newCam.transform.position = camData.transform.position; | ||
newCam.transform.rotation = camData.transform.rotation; | ||
|
||
// Copy camera settings | ||
newCam.CopyFrom(camData); | ||
|
||
// Ensure the custom camera has the same culling mask as the original camera | ||
newCam.cullingMask = camData.cullingMask; | ||
|
||
// Copy other relevant properties | ||
newCam.clearFlags = camData.clearFlags; | ||
newCam.backgroundColor = camData.backgroundColor; | ||
newCam.nearClipPlane = camData.nearClipPlane; | ||
newCam.farClipPlane = camData.farClipPlane; | ||
newCam.fieldOfView = camData.fieldOfView; | ||
newCam.depth = camData.depth; | ||
newCam.renderingPath = camData.renderingPath; | ||
|
||
// this makes it work as the actual camera | ||
newCam.tag = camData.tag; | ||
// add a listener to the camera using the same settings as the original camera | ||
AudioListener? listener = newCam.gameObject.AddComponent<AudioListener>(); | ||
if (listener != null) listener.enabled = true; | ||
if (camData.TryGetComponent(out HDAdditionalCameraData dataToCopy)) { | ||
HDAdditionalCameraData? hdData = newCam.gameObject.AddComponent<HDAdditionalCameraData>(); | ||
if (hdData != null && dataToCopy != null) { | ||
hdData.customRenderingSettings = true; | ||
hdData.renderingPathCustomFrameSettingsOverrideMask.mask = | ||
dataToCopy.renderingPathCustomFrameSettingsOverrideMask.mask; | ||
hdData.renderingPathCustomFrameSettings.SetEnabled(FrameSettingsField.CustomPass, | ||
dataToCopy.renderingPathCustomFrameSettings.IsEnabled(FrameSettingsField.CustomPass)); | ||
hdData.renderingPathCustomFrameSettings.SetEnabled(FrameSettingsField.Volumetrics, | ||
dataToCopy.renderingPathCustomFrameSettings.IsEnabled(FrameSettingsField.Volumetrics)); | ||
hdData.renderingPathCustomFrameSettings.lodBiasMode = | ||
dataToCopy.renderingPathCustomFrameSettings.lodBiasMode; | ||
hdData.renderingPathCustomFrameSettings.lodBias = dataToCopy.renderingPathCustomFrameSettings.lodBias; | ||
hdData.antialiasing = dataToCopy.antialiasing; | ||
hdData.renderingPathCustomFrameSettings.SetEnabled(FrameSettingsField.ShadowMaps, | ||
dataToCopy.renderingPathCustomFrameSettings.IsEnabled(FrameSettingsField.ShadowMaps)); | ||
} | ||
} | ||
|
||
newCam.enabled = true; | ||
CustomCamera = newCam; | ||
return CustomCamera; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a
Hax GameObject
instead? I can do it but I won’t be able to work on this until sometime next week.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the intention is to stop using the player's stock camera, and use one of our own for Phantom and the rest, because it will not influence enemies's AIs , as they mostly target the .GamePlayCamera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Since it’s a core feature, I want it to be added to
Loader
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead, there's no more changes to add to this mod, the camera is stable with @D1GQ 's changes, just sometimes when you die under noclip it breaks, but i haven't figured how to completely kill this bug,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can’t merge with such a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is rare but happens, i haven't got this bug, but i think if we make a core mod out of this, we can sync it with player's death and switch the default camera to activate when the LC-Hax camera is destroyed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is always been a problem just never caused issues with noclip, the problem is when you come back from phantom mode while dead there is a chance to start spectating someone that is dead, and for some reason nocliping breaks with it now.