Add translationMode option to MLRepeater & MLNestedForm formwidgets

[mjauvin]

This allows translating internal fields of Repeater/NestedForm FormWidgets.

See `Repeater/NestedForm formwidget internal fields translation section in README.md for more details.

Fix #21

In order to test this, you can clone this branch with the following git command:

git clone -b wip-ml-repeater-fields [email protected]:wintercms/wn-translate-plugin.git plugins/winter/translate

[mjauvin]

@kubamarkiewicz have you been testing this PR ?
Feedback welcome.

[kubamarkiewicz]

@mjauvin thanks for adding translatable property, I will test it tomorrow

[kubamarkiewicz]

@mjauvin I have tested nestedform with the translatable property in yaml file and it is working correctly! Thanks for adding it.
I have only found a minor css bug related to "fancy-layout" styles: only inside tabs language code has white color over white background so it is not visible, but it is working. I am not sure if this should be fixed in translation plugin or in winter cms styles. I will look for a css fix later.

[kubamarkiewicz]

@mjauvin I have done some more tests and have found a bug. When nested form/repeater definition is not placed in fields.yaml file but instead is located in a separate file and linked to the fields.yaml file like this:

fields:
    data[contacts]:
        type: repeater
        translatable: true
        translationMode: fields
        form: $/kubamarkiewicz/my_plugin/models/record/nested_fields.yaml

then the following error appears:

[mjauvin]

@kubamarkiewicz can you try the fix I just commited ?

Thanks for your help, much appreciated!

[kubamarkiewicz]

@mjauvin now it works! Thanks for the fix.

[kubamarkiewicz]

@mjauvin here it a css fix for the bug with "fancy-layout", that I have commented earlier:

kubamarkiewicz@9fb5c5c

[mjauvin]

@mjauvin here it a css fix for the bug with "fancy-layout", that I have commented earlier:

kubamarkiewicz@9fb5c5c

I added your css fix to this PR.

Thanks.

[nmiyazaki-chapleau]

I tried this PR with the stable version of wn-pages-plugin and saving a static page doesn't work at all because it cannot properly identify the static page title. The title field's translate input name ends up being RLTranslate[en][][viewBag][title], which feels wrong? Not sure, but it refuses to save.

[nmiyazaki-chapleau]

Static pages plugin sets its fields without arrayNames. The title formField's name is viewBag[title] without an arrayName value. This causes the method getLocaleFieldName in traits/MLControl (when isLongFormNeeded() is true) to implode an empty arrayName, thus causing the issue mentionned above.

I'm also realising this is probably normal since this is a BC and other plugins will need to update for this.

[mjauvin]

Static pages plugin sets its fields without arrayNames. The title formField's name is viewBag[title] without an arrayName value. This causes the method getLocaleFieldName in traits/MLControl (when isLongFormNeeded() is true) to implode an empty arrayName, thus causing the issue mentionned above.

I'm also realising this is probably normal since this is a BC and other plugins will need to update for this.

Thanks for reporting this.

I'll need to investigate further, but it might be required for me to cope for the case where the arrayName is not set. Otherwise, we're going to have to make a change to the pages plugin, but it should be doable in this PR.

If you want to experiement with a fix in this PR, please do so as I don't have much time to look into this at the moment.

[nmiyazaki-chapleau]

Just did PR #83 to fix the issue I mentionned, feel free to review.